Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Side by Side Diff: src/processor/stackwalker.cc

Issue 1379433005: Increasing the Breakpad stack walker max scan limit from 30 to 40. (Closed) Base URL: https://chromium.googlesource.com/breakpad/breakpad.git@master
Patch Set: Updating a comment in a test file. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/processor/stackwalker_arm64_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2010 Google Inc. 1 // Copyright (c) 2010 Google Inc.
2 // All rights reserved. 2 // All rights reserved.
3 // 3 //
4 // Redistribution and use in source and binary forms, with or without 4 // Redistribution and use in source and binary forms, with or without
5 // modification, are permitted provided that the following conditions are 5 // modification, are permitted provided that the following conditions are
6 // met: 6 // met:
7 // 7 //
8 // * Redistributions of source code must retain the above copyright 8 // * Redistributions of source code must retain the above copyright
9 // notice, this list of conditions and the following disclaimer. 9 // notice, this list of conditions and the following disclaimer.
10 // * Redistributions in binary form must reproduce the above 10 // * Redistributions in binary form must reproduce the above
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
51 #include "processor/stackwalker_ppc64.h" 51 #include "processor/stackwalker_ppc64.h"
52 #include "processor/stackwalker_sparc.h" 52 #include "processor/stackwalker_sparc.h"
53 #include "processor/stackwalker_x86.h" 53 #include "processor/stackwalker_x86.h"
54 #include "processor/stackwalker_amd64.h" 54 #include "processor/stackwalker_amd64.h"
55 #include "processor/stackwalker_arm.h" 55 #include "processor/stackwalker_arm.h"
56 #include "processor/stackwalker_arm64.h" 56 #include "processor/stackwalker_arm64.h"
57 #include "processor/stackwalker_mips.h" 57 #include "processor/stackwalker_mips.h"
58 58
59 namespace google_breakpad { 59 namespace google_breakpad {
60 60
61 const int Stackwalker::kRASearchWords = 30; 61 const int Stackwalker::kRASearchWords = 40;
62 62
63 uint32_t Stackwalker::max_frames_ = 1024; 63 uint32_t Stackwalker::max_frames_ = 1024;
64 bool Stackwalker::max_frames_set_ = false; 64 bool Stackwalker::max_frames_set_ = false;
65 65
66 uint32_t Stackwalker::max_frames_scanned_ = 1024; 66 uint32_t Stackwalker::max_frames_scanned_ = 1024;
67 67
68 Stackwalker::Stackwalker(const SystemInfo* system_info, 68 Stackwalker::Stackwalker(const SystemInfo* system_info,
69 MemoryRegion* memory, 69 MemoryRegion* memory,
70 const CodeModules* modules, 70 const CodeModules* modules,
71 StackFrameSymbolizer* frame_symbolizer) 71 StackFrameSymbolizer* frame_symbolizer)
(...skipping 214 matching lines...) Expand 10 before | Expand all | Expand 10 after
286 symbolizer_result != StackFrameSymbolizer::kWarningCorruptSymbols) { 286 symbolizer_result != StackFrameSymbolizer::kWarningCorruptSymbols) {
287 // Some error occurred during symbolization, but the address is within a 287 // Some error occurred during symbolization, but the address is within a
288 // known module 288 // known module
289 return true; 289 return true;
290 } 290 }
291 291
292 return !frame.function_name.empty(); 292 return !frame.function_name.empty();
293 } 293 }
294 294
295 } // namespace google_breakpad 295 } // namespace google_breakpad
OLDNEW
« no previous file with comments | « no previous file | src/processor/stackwalker_arm64_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698