Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(510)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 137933002: Update more platform classes to use OVERRIDE / FINAL when needed (Closed)

Created:
6 years, 11 months ago by Inactive
Modified:
6 years, 11 months ago
CC:
blink-reviews, jamesr, krit, dsinclair, philipj_slow, jbroman, Raymond Toy, danakj, feature-media-reviews_chromium.org, Rik, Stephen Chennney, rwlbuis
Visibility:
Public.

Description

Update more platform classes to use OVERRIDE / FINAL when needed Update more platform classes to use OVERRIDE / FINAL when needed. Those are useful for error checking or performance when the compiler supports it. These were found using the chromium style clang plugin. R=abarth, eseidel BUG=333316 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165327

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -94 lines) Patch
M Source/platform/JSONValues.h View 6 chunks +17 lines, -17 lines 0 comments Download
M Source/platform/audio/HRTFPanner.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/platform/audio/MultiChannelResampler.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/platform/audio/SincResampler.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/platform/drm/ContentDecryptionModuleSession.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/exported/WebScrollbarThemeClientImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/DiscardablePixelRef.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/filters/DistantLightSource.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/platform/graphics/filters/FEBlend.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/filters/FEColorMatrix.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/filters/FEComponentTransfer.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/filters/FEComposite.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/filters/FEConvolveMatrix.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/filters/FEDiffuseLighting.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/filters/FEDisplacementMap.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/filters/FEDropShadow.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/filters/FEFlood.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/filters/FEGaussianBlur.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/filters/FEMerge.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/filters/FEMorphology.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/filters/FEOffset.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/filters/FESpecularLighting.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/filters/FETile.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/platform/graphics/filters/FETurbulence.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/filters/FilterOperation.h View 6 chunks +12 lines, -12 lines 0 comments Download
M Source/platform/graphics/filters/PointLightSource.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/platform/graphics/filters/ReferenceFilter.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/platform/graphics/filters/SourceAlpha.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/platform/graphics/filters/SourceGraphic.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/platform/graphics/filters/SpotLightSource.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/platform/graphics/gpu/DrawingBuffer.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/network/WebSocketHandshakeRequest.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/scroll/FramelessScrollView.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/scroll/ScrollView.h View 4 chunks +5 lines, -5 lines 0 comments Download
M Source/platform/scroll/ScrollbarThemeGtkOrAura.h View 1 chunk +7 lines, -7 lines 0 comments Download
M Source/platform/transforms/IdentityTransformOperation.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/transforms/InterpolatedTransformOperation.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/transforms/Matrix3DTransformOperation.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/transforms/MatrixTransformOperation.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/transforms/PerspectiveTransformOperation.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/transforms/RotateTransformOperation.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/transforms/ScaleTransformOperation.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/transforms/SkewTransformOperation.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/transforms/TranslateTransformOperation.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Inactive
6 years, 11 months ago (2014-01-14 07:18:20 UTC) #1
Inactive
ping review?
6 years, 11 months ago (2014-01-17 18:18:25 UTC) #2
pdr.
On 2014/01/17 18:18:25, Chris Dumez wrote: > ping review? LGTM
6 years, 11 months ago (2014-01-17 18:22:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/137933002/1
6 years, 11 months ago (2014-01-17 18:28:05 UTC) #4
commit-bot: I haz the power
6 years, 11 months ago (2014-01-17 19:19:59 UTC) #5
Message was sent while issue was closed. 
Change committed as 165327

Powered by Google App Engine
This is Rietveld 408576698