Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 137893021: Make sure to initialize a boolean in ExtensionSettingsHandler (Closed)

Created:
6 years, 11 months ago by asargent_no_longer_on_chrome
Modified:
6 years, 11 months ago
Reviewers:
Finnur
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Make sure to initialize a boolean in ExtensionSettingsHandler It turns out there are 2 constructors, and this boolean was only being initialized to false in one of them. This caused an extension install verification request to the verification server on every load of the chrome://extensions page (regardless of whether the user had any disabled-due-to-verification-failure extensions). Also add a histogram for tracking the number of ids that we tried to verify which the server replied were invalid (ie not known to be in the webstore). BUG=335379 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245535

Patch Set 1 #

Patch Set 2 : added histogram for count of unverified ids #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M chrome/browser/extensions/install_signer.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/extensions/extension_settings_handler.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
asargent_no_longer_on_chrome
Finnur - please take a look. If this lg to you, can you also hit ...
6 years, 11 months ago (2014-01-17 07:44:35 UTC) #1
Finnur
LGTM, in CQ.
6 years, 11 months ago (2014-01-17 12:18:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asargent@chromium.org/137893021/20001
6 years, 11 months ago (2014-01-17 12:19:27 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=247978
6 years, 11 months ago (2014-01-17 14:00:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asargent@chromium.org/137893021/20001
6 years, 11 months ago (2014-01-17 14:51:08 UTC) #5
commit-bot: I haz the power
6 years, 11 months ago (2014-01-17 17:00:19 UTC) #6
Message was sent while issue was closed.
Change committed as 245535

Powered by Google App Engine
This is Rietveld 408576698