chrome/browser/extensions/install_signer.cc - Issue 137893021: Make sure to initialize a boolean in ExtensionSettingsHandler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/install_signer.cc

Issue 137893021: Make sure to initialize a boolean in ExtensionSettingsHandler (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: added histogram for count of unverified ids Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/install_signer.cc

diff --git a/chrome/browser/extensions/install_signer.cc b/chrome/browser/extensions/install_signer.cc

index 24c68d62c871f4f3b7c01a8419a9448d9fc35d28..b8f9d58265b422730a394e488987a873d3c849a7 100644

--- a/chrome/browser/extensions/install_signer.cc

+++ b/chrome/browser/extensions/install_signer.cc

@@ -383,6 +383,8 @@ void InstallSigner::HandleSignatureResult(const std::string& signature,

result->expire_date = expire_date;

bool verified = VerifySignature(*result);

UMA_HISTOGRAM_BOOLEAN("ExtensionInstallSigner.ResultWasValid", verified);

+ UMA_HISTOGRAM_COUNTS_100("ExtensionInstallSigner.InvalidCount",

+ invalid_ids.size());

if (!verified)

result.reset();

}

« no previous file with comments | « no previous file | chrome/browser/ui/webui/extensions/extension_settings_handler.cc » ('j') | no next file with comments »