Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Side by Side Diff: chrome/browser/ui/webui/extensions/extension_settings_handler.cc

Issue 137893021: Make sure to initialize a boolean in ExtensionSettingsHandler (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: added histogram for count of unverified ids Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/extensions/install_signer.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/webui/extensions/extension_settings_handler.h" 5 #include "chrome/browser/ui/webui/extensions/extension_settings_handler.h"
6 6
7 #include "apps/app_load_service.h" 7 #include "apps/app_load_service.h"
8 #include "apps/app_restore_service.h" 8 #include "apps/app_restore_service.h"
9 #include "apps/saved_files_service.h" 9 #include "apps/saved_files_service.h"
10 #include "apps/shell_window.h" 10 #include "apps/shell_window.h"
(...skipping 136 matching lines...) Expand 10 before | Expand all | Expand 10 after
147 147
148 ExtensionSettingsHandler::ExtensionSettingsHandler() 148 ExtensionSettingsHandler::ExtensionSettingsHandler()
149 : extension_service_(NULL), 149 : extension_service_(NULL),
150 management_policy_(NULL), 150 management_policy_(NULL),
151 ignore_notifications_(false), 151 ignore_notifications_(false),
152 deleting_rvh_(NULL), 152 deleting_rvh_(NULL),
153 deleting_rwh_id_(-1), 153 deleting_rwh_id_(-1),
154 deleting_rph_id_(-1), 154 deleting_rph_id_(-1),
155 registered_for_notifications_(false), 155 registered_for_notifications_(false),
156 warning_service_observer_(this), 156 warning_service_observer_(this),
157 error_console_observer_(this) { 157 error_console_observer_(this),
158 should_do_verification_check_(false) {
158 } 159 }
159 160
160 ExtensionSettingsHandler::~ExtensionSettingsHandler() { 161 ExtensionSettingsHandler::~ExtensionSettingsHandler() {
161 // There may be pending file dialogs, we need to tell them that we've gone 162 // There may be pending file dialogs, we need to tell them that we've gone
162 // away so they don't try and call back to us. 163 // away so they don't try and call back to us.
163 if (load_extension_dialog_.get()) 164 if (load_extension_dialog_.get())
164 load_extension_dialog_->ListenerDestroyed(); 165 load_extension_dialog_->ListenerDestroyed();
165 } 166 }
166 167
167 ExtensionSettingsHandler::ExtensionSettingsHandler(ExtensionService* service, 168 ExtensionSettingsHandler::ExtensionSettingsHandler(ExtensionService* service,
(...skipping 1075 matching lines...) Expand 10 before | Expand all | Expand 10 after
1243 extension_service_->EnableExtension(extension_id); 1244 extension_service_->EnableExtension(extension_id);
1244 } else { 1245 } else {
1245 ExtensionErrorReporter::GetInstance()->ReportError( 1246 ExtensionErrorReporter::GetInstance()->ReportError(
1246 base::UTF8ToUTF16(JoinString(requirement_errors, ' ')), 1247 base::UTF8ToUTF16(JoinString(requirement_errors, ' ')),
1247 true /* be noisy */); 1248 true /* be noisy */);
1248 } 1249 }
1249 requirements_checker_.reset(); 1250 requirements_checker_.reset();
1250 } 1251 }
1251 1252
1252 } // namespace extensions 1253 } // namespace extensions
OLDNEW
« no previous file with comments | « chrome/browser/extensions/install_signer.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698