Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Issue 1378843003: Remove the 'name' and 'length' getters from IndexableObject. (Closed)

Created:
5 years, 2 months ago by scheglov
Modified:
5 years, 2 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove the 'name' and 'length' getters from IndexableObject. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/147581cf346fb4f8d30835f39f073bc686623e1e

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -70 lines) Patch
M pkg/analysis_server/lib/analysis/index_core.dart View 5 chunks +23 lines, -24 lines 2 comments Download
M pkg/analysis_server/lib/src/services/index/index.dart View 2 chunks +6 lines, -3 lines 0 comments Download
M pkg/analysis_server/lib/src/services/index/index_contributor.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/services/index/indexable_element.dart View 5 chunks +19 lines, -8 lines 0 comments Download
M pkg/analysis_server/lib/src/services/index/store/codec.dart View 5 chunks +3 lines, -22 lines 0 comments Download
M pkg/analysis_server/lib/src/services/index/store/split_store.dart View 2 chunks +5 lines, -8 lines 0 comments Download
M pkg/analysis_server/test/services/index/store/codec_test.dart View 4 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
scheglov
5 years, 2 months ago (2015-10-04 22:30:04 UTC) #1
Brian Wilkerson
LGTM https://codereview.chromium.org/1378843003/diff/1/pkg/analysis_server/lib/analysis/index_core.dart File pkg/analysis_server/lib/analysis/index_core.dart (right): https://codereview.chromium.org/1378843003/diff/1/pkg/analysis_server/lib/analysis/index_core.dart#newcode85 pkg/analysis_server/lib/analysis/index_core.dart:85: * Returns an integer that corresponds to the ...
5 years, 2 months ago (2015-10-05 14:01:02 UTC) #2
scheglov
Committed patchset #1 (id:1) manually as 147581cf346fb4f8d30835f39f073bc686623e1e (presubmit successful).
5 years, 2 months ago (2015-10-05 14:27:55 UTC) #3
scheglov
5 years, 2 months ago (2015-10-05 14:28:17 UTC) #4
Message was sent while issue was closed.
https://codereview.chromium.org/1378843003/diff/1/pkg/analysis_server/lib/ana...
File pkg/analysis_server/lib/analysis/index_core.dart (right):

https://codereview.chromium.org/1378843003/diff/1/pkg/analysis_server/lib/ana...
pkg/analysis_server/lib/analysis/index_core.dart:85: * Returns an integer that
corresponds to the name of [indexable].
On 2015/10/05 14:01:02, Brian Wilkerson wrote:
> This needs to be more complete. What should it return in the indexable object
> doesn't have a name? Why does IndexableElementKind combine the integer
> corresponding to the name and the integer corresponding to the library's file
> path? (The requirement that causes us to do that needs to be explicit in the
> comment so that plugin authors know what they need to do.)

Done.

Powered by Google App Engine
This is Rietveld 408576698