Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Unified Diff: pkg/analysis_server/test/services/index/store/codec_test.dart

Issue 1378843003: Remove the 'name' and 'length' getters from IndexableObject. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/test/services/index/store/codec_test.dart
diff --git a/pkg/analysis_server/test/services/index/store/codec_test.dart b/pkg/analysis_server/test/services/index/store/codec_test.dart
index 43dbe33ba524451103ad121ae55e7795eb35caf6..5e6d180c1c2f7719c2d4ae6c243bdc3b2f1c3d64 100644
--- a/pkg/analysis_server/test/services/index/store/codec_test.dart
+++ b/pkg/analysis_server/test/services/index/store/codec_test.dart
@@ -93,7 +93,7 @@ part 'my_part.dart';
int id2 = codec.encode2(indexable);
int id3 = codec.encode3(indexable);
expect(id1, isNonNegative);
- expect(id2, isNonNegative);
+ expect(id2, -1);
expect(id3, IndexableElementKind.forElement(element).index);
validateDecode(id1, id2, id3, element);
}
@@ -106,7 +106,7 @@ part 'my_part.dart';
int id2 = codec.encode2(indexable);
int id3 = codec.encode3(indexable);
expect(id1, isNonNegative);
- expect(id2, isNonNegative);
+ expect(id2, -1);
expect(id3, IndexableElementKind.forElement(element).index);
validateDecode(id1, id2, id3, element);
}
@@ -260,6 +260,7 @@ class A {
expect(id1, -1);
expect(id2, isNonNegative);
expect(id3, IndexableNameKind.INSTANCE.index);
+ expect(codec.decode(context, id1, id2, id3), indexable);
}
void test_encode_LibraryElement() {
@@ -274,7 +275,7 @@ class A {
int id2 = codec.encode2(indexable);
int id3 = codec.encode3(indexable);
expect(id1, isNonNegative);
- expect(id2, isNonNegative);
+ expect(id2, -1);
expect(id3, IndexableElementKind.forElement(element).index);
validateDecode(id1, id2, id3, element);
}

Powered by Google App Engine
This is Rietveld 408576698