Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(888)

Unified Diff: pkg/analysis_server/lib/src/services/index/store/split_store.dart

Issue 1378843003: Remove the 'name' and 'length' getters from IndexableObject. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/lib/src/services/index/store/split_store.dart
diff --git a/pkg/analysis_server/lib/src/services/index/store/split_store.dart b/pkg/analysis_server/lib/src/services/index/store/split_store.dart
index 9c51d6ac0131ff06a7edac36a533e5160cb34e42..57b173487189abdca5fbb0922efe8110279adcf7 100644
--- a/pkg/analysis_server/lib/src/services/index/store/split_store.dart
+++ b/pkg/analysis_server/lib/src/services/index/store/split_store.dart
@@ -1005,8 +1005,8 @@ class SplitIndexStore implements InternalIndexStore {
nodeDeclarations[_currentNodeNameId] = declarations;
}
// record LocationData
- declarations
- .add(new _TopElementData(_elementCodec, new IndexableElement(element)));
+ declarations.add(new _TopElementData(
+ _elementCodec, element.displayName, new IndexableElement(element)));
}
@override
@@ -1154,12 +1154,9 @@ class _TopElementData {
final int elementId3;
factory _TopElementData(
- ElementCodec elementCodec, IndexableObject indexable) {
- return new _TopElementData._(
- indexable.name,
- elementCodec.encode1(indexable),
- elementCodec.encode2(indexable),
- elementCodec.encode3(indexable));
+ ElementCodec elementCodec, String name, IndexableObject indexable) {
+ return new _TopElementData._(name, elementCodec.encode1(indexable),
+ elementCodec.encode2(indexable), elementCodec.encode3(indexable));
}
_TopElementData._(

Powered by Google App Engine
This is Rietveld 408576698