Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 1378563002: [arm] Fix a double-register push operation. (Closed)

Created:
5 years, 2 months ago by jbramley
Modified:
5 years, 2 months ago
Reviewers:
Benedikt Meurer, ulan
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[arm] Fix a double-register push operation. It is not safe to access memory below sp, and this is also forbidden by the ABI. When pushing, we must either use an atomic operation (such as vstm+db_w) or move sp before writing the data. This patch fixes one stack access, and also adds vpush and vpop helpers to simplify similar code. BUG= Committed: https://crrev.com/f20d6461526eaf1ee1306e6e6048e06ae0f1688c Cr-Commit-Position: refs/heads/master@{#31008}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -5 lines) Patch
M src/arm/assembler-arm.h View 1 chunk +8 lines, -0 lines 0 comments Download
M src/arm/assembler-arm.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M src/arm/lithium-gap-resolver-arm.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/arm/code-generator-arm.cc View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jbramley
5 years, 2 months ago (2015-09-29 08:43:11 UTC) #2
Benedikt Meurer
lgtm
5 years, 2 months ago (2015-09-29 14:45:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1378563002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1378563002/1
5 years, 2 months ago (2015-09-29 14:45:49 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-29 15:11:26 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-09-29 15:11:37 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f20d6461526eaf1ee1306e6e6048e06ae0f1688c
Cr-Commit-Position: refs/heads/master@{#31008}

Powered by Google App Engine
This is Rietveld 408576698