Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Side by Side Diff: src/arm/lithium-gap-resolver-arm.cc

Issue 1378563002: [arm] Fix a double-register push operation. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/arm/assembler-arm.cc ('k') | src/compiler/arm/code-generator-arm.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/arm/lithium-codegen-arm.h" 5 #include "src/arm/lithium-codegen-arm.h"
6 #include "src/arm/lithium-gap-resolver-arm.h" 6 #include "src/arm/lithium-gap-resolver-arm.h"
7 7
8 namespace v8 { 8 namespace v8 {
9 namespace internal { 9 namespace internal {
10 10
(...skipping 260 matching lines...) Expand 10 before | Expand all | Expand 10 after
271 271
272 } else if (source->IsDoubleStackSlot()) { 272 } else if (source->IsDoubleStackSlot()) {
273 MemOperand source_operand = cgen_->ToMemOperand(source); 273 MemOperand source_operand = cgen_->ToMemOperand(source);
274 if (destination->IsDoubleRegister()) { 274 if (destination->IsDoubleRegister()) {
275 __ vldr(cgen_->ToDoubleRegister(destination), source_operand); 275 __ vldr(cgen_->ToDoubleRegister(destination), source_operand);
276 } else { 276 } else {
277 DCHECK(destination->IsDoubleStackSlot()); 277 DCHECK(destination->IsDoubleStackSlot());
278 MemOperand destination_operand = cgen_->ToMemOperand(destination); 278 MemOperand destination_operand = cgen_->ToMemOperand(destination);
279 if (in_cycle_) { 279 if (in_cycle_) {
280 // kScratchDoubleReg was used to break the cycle. 280 // kScratchDoubleReg was used to break the cycle.
281 __ vstm(db_w, sp, kScratchDoubleReg, kScratchDoubleReg); 281 __ vpush(kScratchDoubleReg);
282 __ vldr(kScratchDoubleReg, source_operand); 282 __ vldr(kScratchDoubleReg, source_operand);
283 __ vstr(kScratchDoubleReg, destination_operand); 283 __ vstr(kScratchDoubleReg, destination_operand);
284 __ vldm(ia_w, sp, kScratchDoubleReg, kScratchDoubleReg); 284 __ vpop(kScratchDoubleReg);
285 } else { 285 } else {
286 __ vldr(kScratchDoubleReg, source_operand); 286 __ vldr(kScratchDoubleReg, source_operand);
287 __ vstr(kScratchDoubleReg, destination_operand); 287 __ vstr(kScratchDoubleReg, destination_operand);
288 } 288 }
289 } 289 }
290 } else { 290 } else {
291 UNREACHABLE(); 291 UNREACHABLE();
292 } 292 }
293 293
294 moves_[index].Eliminate(); 294 moves_[index].Eliminate();
295 } 295 }
296 296
297 297
298 #undef __ 298 #undef __
299 299
300 } // namespace internal 300 } // namespace internal
301 } // namespace v8 301 } // namespace v8
OLDNEW
« no previous file with comments | « src/arm/assembler-arm.cc ('k') | src/compiler/arm/code-generator-arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698