Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Side by Side Diff: src/compiler/arm/code-generator-arm.cc

Issue 1378563002: [arm] Fix a double-register push operation. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/arm/lithium-gap-resolver-arm.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler/code-generator.h" 5 #include "src/compiler/code-generator.h"
6 6
7 #include "src/arm/macro-assembler-arm.h" 7 #include "src/arm/macro-assembler-arm.h"
8 #include "src/compiler/code-generator-impl.h" 8 #include "src/compiler/code-generator-impl.h"
9 #include "src/compiler/gap-resolver.h" 9 #include "src/compiler/gap-resolver.h"
10 #include "src/compiler/node-matchers.h" 10 #include "src/compiler/node-matchers.h"
(...skipping 813 matching lines...) Expand 10 before | Expand all | Expand 10 after
824 break; 824 break;
825 case kArmVstrF64: { 825 case kArmVstrF64: {
826 size_t index = 0; 826 size_t index = 0;
827 MemOperand operand = i.InputOffset(&index); 827 MemOperand operand = i.InputOffset(&index);
828 __ vstr(i.InputFloat64Register(index), operand); 828 __ vstr(i.InputFloat64Register(index), operand);
829 DCHECK_EQ(LeaveCC, i.OutputSBit()); 829 DCHECK_EQ(LeaveCC, i.OutputSBit());
830 break; 830 break;
831 } 831 }
832 case kArmPush: 832 case kArmPush:
833 if (instr->InputAt(0)->IsDoubleRegister()) { 833 if (instr->InputAt(0)->IsDoubleRegister()) {
834 __ vstr(i.InputDoubleRegister(0), MemOperand(sp, -kDoubleSize)); 834 __ vpush(i.InputDoubleRegister(0));
835 __ sub(sp, sp, Operand(kDoubleSize));
836 } else { 835 } else {
837 __ Push(i.InputRegister(0)); 836 __ push(i.InputRegister(0));
838 } 837 }
839 DCHECK_EQ(LeaveCC, i.OutputSBit()); 838 DCHECK_EQ(LeaveCC, i.OutputSBit());
840 break; 839 break;
841 case kArmPoke: { 840 case kArmPoke: {
842 int const slot = MiscField::decode(instr->opcode()); 841 int const slot = MiscField::decode(instr->opcode());
843 __ str(i.InputRegister(0), MemOperand(sp, slot * kPointerSize)); 842 __ str(i.InputRegister(0), MemOperand(sp, slot * kPointerSize));
844 DCHECK_EQ(LeaveCC, i.OutputSBit()); 843 DCHECK_EQ(LeaveCC, i.OutputSBit());
845 break; 844 break;
846 } 845 }
847 case kArmStoreWriteBarrier: { 846 case kArmStoreWriteBarrier: {
(...skipping 429 matching lines...) Expand 10 before | Expand all | Expand 10 after
1277 padding_size -= v8::internal::Assembler::kInstrSize; 1276 padding_size -= v8::internal::Assembler::kInstrSize;
1278 } 1277 }
1279 } 1278 }
1280 } 1279 }
1281 1280
1282 #undef __ 1281 #undef __
1283 1282
1284 } // namespace compiler 1283 } // namespace compiler
1285 } // namespace internal 1284 } // namespace internal
1286 } // namespace v8 1285 } // namespace v8
OLDNEW
« no previous file with comments | « src/arm/lithium-gap-resolver-arm.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698