Issue 1378183003: Revert "wrap_jso should wrap JsArray as well, not always call wrap on its contents"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1378183003: Revert "wrap_jso should wrap JsArray as well, not always call wrap on its contents" (Closed)

Created:
5 years, 2 months ago by Alan Knight

Modified:
5 years, 2 months ago

Reviewers:

CC:
reviews_dartlang.org, ricow1

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Revert "wrap_jso should wrap JsArray as well, not always call wrap on its contents" This reverts commit f0e52e4e9175c10739645b6a1f72d551f6b9fd06. BUG= Committed: https://github.com/dart-lang/sdk/commit/da7d6379ccde075dc538ed2df4409d2a44fc94d9

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -73 lines)			Patch
M	sdk/lib/html/dartium/html_dartium.dart	View	3 chunks	+1 line, -23 lines	0 comments	Download
M	sdk/lib/js/dartium/js_dartium.dart	View	1 chunk	+5 lines, -1 line	0 comments	Download
M	tests/html/html.status	View	1 chunk	+1 line, -0 lines	0 comments	Download
D	tests/html/wrapping_collections_test.dart	View	1 chunk	+0 lines, -26 lines	0 comments	Download
M	tools/dom/templates/html/dartium/html_dartium.darttemplate	View	2 chunks	+0 lines, -22 lines	0 comments	Download
M	tools/dom/templates/html/impl/impl_MutationObserver.darttemplate	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 1 (0 generated)

Alan Knight

5 years, 2 months ago (2015-10-02 00:51:56 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
da7d6379ccde075dc538ed2df4409d2a44fc94d9 (presubmit successful).