Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Unified Diff: sdk/lib/js/dartium/js_dartium.dart

Issue 1378183003: Revert "wrap_jso should wrap JsArray as well, not always call wrap on its contents" (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/html/dartium/html_dartium.dart ('k') | tests/html/html.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/js/dartium/js_dartium.dart
diff --git a/sdk/lib/js/dartium/js_dartium.dart b/sdk/lib/js/dartium/js_dartium.dart
index f0e653b123a3555d515adc0cb992963722f077a1..2e4d9050afd094e2dc80e4f12dfd13ff2f88dfb2 100644
--- a/sdk/lib/js/dartium/js_dartium.dart
+++ b/sdk/lib/js/dartium/js_dartium.dart
@@ -807,7 +807,11 @@ class JsArray<E> extends JsObject with ListMixin<E> {
_checkIndex(index);
}
- return super[index];
+ // Lazily create the Dart class that wraps the JS object when the object in
+ // a list if fetched.
+ var wrap_entry = html.wrap_jso(super[index]);
+ super[index] = wrap_entry;
+ return wrap_entry;
}
void operator []=(index, E value) {
« no previous file with comments | « sdk/lib/html/dartium/html_dartium.dart ('k') | tests/html/html.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698