Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Unified Diff: sdk/lib/html/dartium/html_dartium.dart

Issue 1378183003: Revert "wrap_jso should wrap JsArray as well, not always call wrap on its contents" (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « no previous file | sdk/lib/js/dartium/js_dartium.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/html/dartium/html_dartium.dart
diff --git a/sdk/lib/html/dartium/html_dartium.dart b/sdk/lib/html/dartium/html_dartium.dart
index 9c71b288bbeb5122672d80a2c7099a8495838055..58de55c59a34b4bd5cc701155a4e51780e241f99 100644
--- a/sdk/lib/html/dartium/html_dartium.dart
+++ b/sdk/lib/html/dartium/html_dartium.dart
@@ -1159,12 +1159,6 @@ wrap_jso(jsObject) {
return wrapper;
}
- if (jsObject is js.JsArray) {
- var wrappingList = new _DartHtmlWrappingList(jsObject);
- js.setDartHtmlWrapperFor(jsObject, wrappingList);
- return wrappingList;
- }
-
// Try the most general type conversions on it.
// TODO(alanknight): We may be able to do better. This maintains identity,
// which is useful, but expensive. And if we nest something that only
@@ -1310,22 +1304,6 @@ convertDartToNative_List(List input) => new js.JsArray()..addAll(input);
// Conversion function place holder (currently not used in dart2js or dartium).
List convertDartToNative_StringArray(List<String> input) => input;
-/**
- * Wraps a JsArray and will call wrap_jso on its entries.
- */
-class _DartHtmlWrappingList extends ListBase {
- _DartHtmlWrappingList(this._basicList);
-
- final js.JsArray _basicList;
-
- operator [](int index) => wrap_jso(_basicList[index]);
-
- operator []=(int index, value) => _basicList[index] = unwrap_jso(value);
-
- int get length => _basicList.length;
- int set length(int newLength) => _basicList.length = newLength;
-}
-
// Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
@@ -27262,7 +27240,7 @@ class MutationObserver extends NativeFieldWrapperClass2 {
}
@DocsEditable()
static MutationObserver _create(callback) => wrap_jso(_blink.BlinkMutationObserver.instance.constructorCallback_1_((mutations, observer) {
- callback(wrap_jso(mutations), wrap_jso(observer));
+ callback(mutations, wrap_jso(observer));
}));
/**
« no previous file with comments | « no previous file | sdk/lib/js/dartium/js_dartium.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698