Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Unified Diff: chrome/browser/extensions/api/management/management_api_constants.cc

Issue 137793011: Require user confirmation for chrome.management.uninstall except when uninstalling self. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix ExtensionManagementApiBrowserTest.LaunchApp Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/management/management_api_constants.cc
diff --git a/chrome/browser/extensions/api/management/management_api_constants.cc b/chrome/browser/extensions/api/management/management_api_constants.cc
index 0a923f5134dd18d4b2c54ab060280be04021ca56..8be22c77caa06152d885ce6dd2db83b0c91e71b7 100644
--- a/chrome/browser/extensions/api/management/management_api_constants.cc
+++ b/chrome/browser/extensions/api/management/management_api_constants.cc
@@ -14,13 +14,16 @@ const char kExtensionCreateError[] =
"Failed to create extension from manifest.";
const char kGestureNeededForEscalationError[] =
"Re-enabling an extension disabled due to permissions increase "
- "requires a user gesture";
+ "requires a user gesture.";
+const char kGestureNeededForUninstallError[] =
+ "chrome.management.uninstall requires a user gesture.";
const char kManifestParseError[] = "Failed to parse manifest.";
-const char kNoExtensionError[] = "Failed to find extension with id *";
-const char kNotAnAppError[] = "Extension * is not an App";
-const char kUserCantModifyError[] = "Extension * cannot be modified by user";
-const char kUninstallCanceledError[] = "Extension * uninstall canceled by user";
+const char kNoExtensionError[] = "Failed to find extension with id *.";
+const char kNotAnAppError[] = "Extension * is not an App.";
+const char kUserCantModifyError[] = "Extension * cannot be modified by user.";
+const char kUninstallCanceledError[] =
+ "Extension * uninstall canceled by user.";
const char kUserDidNotReEnableError[] =
- "The user did not accept the re-enable dialog";
+ "The user did not accept the re-enable dialog.";
} // namespace extension_management_api_constants

Powered by Google App Engine
This is Rietveld 408576698