Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1377853004: XFA: Remove test for new. (Closed)

Created:
5 years, 2 months ago by Lei Zhang
Modified:
5 years, 2 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 3

Patch Set 2 : rebase #

Patch Set 3 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -150 lines) Patch
M fpdfsdk/src/fpdfxfa/fpdfxfa_doc.cpp View 1 2 2 chunks +3 lines, -12 lines 0 comments Download
M xfa/include/fxfa/fxfa_widget.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fdp/src/css/fde_cssstylesheet.cpp View 2 chunks +0 lines, -6 lines 0 comments Download
M xfa/src/fdp/src/fde/fde_gedevice.cpp View 1 chunk +1 line, -7 lines 0 comments Download
M xfa/src/fdp/src/xml/fde_xml.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fgas/src/crt/fx_stream.cpp View 9 chunks +6 lines, -69 lines 0 comments Download
M xfa/src/fgas/src/font/fx_stdfontmgr.cpp View 6 chunks +2 lines, -22 lines 0 comments Download
M xfa/src/fxbarcode/BC_Writer.cpp View 1 chunk +2 lines, -5 lines 0 comments Download
M xfa/src/fxfa/src/app/xfa_ffapp.cpp View 2 chunks +0 lines, -6 lines 0 comments Download
M xfa/src/fxfa/src/app/xfa_ffdoc.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M xfa/src/fxfa/src/app/xfa_ffwidgetacc.cpp View 4 chunks +8 lines, -11 lines 0 comments Download
M xfa/src/fxfa/src/parser/xfa_object_imp.cpp View 2 chunks +0 lines, -6 lines 0 comments Download
M xfa/src/fxjse/src/class.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Lei Zhang
5 years, 2 months ago (2015-10-01 20:06:48 UTC) #2
Tom Sepez
lgtm https://codereview.chromium.org/1377853004/diff/1/fpdfsdk/src/fpdfxfa/fpdfxfa_doc.cpp File fpdfsdk/src/fpdfxfa/fpdfxfa_doc.cpp (right): https://codereview.chromium.org/1377853004/diff/1/fpdfsdk/src/fpdfxfa/fpdfxfa_doc.cpp#newcode203 fpdfsdk/src/fpdfxfa/fpdfxfa_doc.cpp:203: if (!pFormFillEnv) nit: how about just: if (pFormFillEnv ...
5 years, 2 months ago (2015-10-02 17:12:11 UTC) #3
Tom Sepez
> nit: how about just: > > if (pFormFillEnv && !m_pSDKDoc) > m_pSDKDoc = new ...
5 years, 2 months ago (2015-10-02 17:15:18 UTC) #4
Lei Zhang
https://codereview.chromium.org/1377853004/diff/1/fpdfsdk/src/fpdfxfa/fpdfxfa_doc.cpp File fpdfsdk/src/fpdfxfa/fpdfxfa_doc.cpp (right): https://codereview.chromium.org/1377853004/diff/1/fpdfsdk/src/fpdfxfa/fpdfxfa_doc.cpp#newcode203 fpdfsdk/src/fpdfxfa/fpdfxfa_doc.cpp:203: if (!pFormFillEnv) On 2015/10/02 17:12:11, Tom Sepez wrote: > ...
5 years, 2 months ago (2015-10-02 17:21:52 UTC) #6
Lei Zhang
5 years, 2 months ago (2015-10-02 17:22:18 UTC) #7
Message was sent while issue was closed. 
Committed patchset #3 (id:60001) manually as
421b4612439ee3a81d675b542038c6c3ff25e977 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698