Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Unified Diff: fpdfsdk/src/fpdfxfa/fpdfxfa_doc.cpp

Issue 1377853004: XFA: Remove test for new. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@xfa
Patch Set: nit Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | xfa/include/fxfa/fxfa_widget.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: fpdfsdk/src/fpdfxfa/fpdfxfa_doc.cpp
diff --git a/fpdfsdk/src/fpdfxfa/fpdfxfa_doc.cpp b/fpdfsdk/src/fpdfxfa/fpdfxfa_doc.cpp
index 9378735c24d26f4447fba5b6da4a7d2d76c1afa8..249efae759900f98d36bf339f3d797c9b2e26d3b 100644
--- a/fpdfsdk/src/fpdfxfa/fpdfxfa_doc.cpp
+++ b/fpdfsdk/src/fpdfxfa/fpdfxfa_doc.cpp
@@ -200,16 +200,8 @@ void CPDFXFA_Document::RemovePage(CPDFXFA_Page* page) {
CPDFSDK_Document* CPDFXFA_Document::GetSDKDocument(
CPDFDoc_Environment* pFormFillEnv) {
- if (!pFormFillEnv)
- return m_pSDKDoc;
-
- if (m_pSDKDoc)
- return m_pSDKDoc;
-
- m_pSDKDoc = new CPDFSDK_Document(this, pFormFillEnv);
- if (!m_pSDKDoc)
- return NULL;
-
+ if (!m_pSDKDoc && pFormFillEnv)
+ m_pSDKDoc = new CPDFSDK_Document(this, pFormFillEnv);
return m_pSDKDoc;
}
@@ -999,8 +991,7 @@ IFX_FileRead* CPDFXFA_Document::OpenLinkedFile(IXFA_Doc* hDoc,
if (pFileHandler == NULL)
return NULL;
- CFPDF_FileStream* pFileRead = new CFPDF_FileStream(pFileHandler);
- return pFileRead;
+ return new CFPDF_FileStream(pFileHandler);
}
FX_BOOL CPDFXFA_Document::_ExportSubmitFile(FPDF_FILEHANDLER* pFileHandler,
int fileType,
« no previous file with comments | « no previous file | xfa/include/fxfa/fxfa_widget.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698