XFA: Remove test for new.

fpdfsdk/src/fpdfxfa/fpdfxfa_doc.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "../../../public/fpdf_formfill.h"
 #include "../../include/fsdk_define.h"
 #include "../../include/fpdfxfa/fpdfxfa_doc.h"
 #include "../../include/fsdk_mgr.h"
@@ skipping 182 matching lines @@
 
   return NULL;
 }
 
 void CPDFXFA_Document::RemovePage(CPDFXFA_Page* page) {
   m_XFAPageList.SetAt(page->GetPageIndex(), NULL);
 }
 
 CPDFSDK_Document* CPDFXFA_Document::GetSDKDocument(
     CPDFDoc_Environment* pFormFillEnv) {
   if (!pFormFillEnv)

[Tom Sepez, 2015/10/02 17:12:11]

nit: how about just:

if (pFormFillEnv && !m_pSDKDoc)
  m_pSDKDoc = new ...;

return m_pSDKDoc;

[Lei Zhang, 2015/10/02 17:21:52]

Done.

     return m_pSDKDoc;
 
   if (m_pSDKDoc)
     return m_pSDKDoc;
 
   m_pSDKDoc = new CPDFSDK_Document(this, pFormFillEnv);
-  if (!m_pSDKDoc)
-    return NULL;
-
   return m_pSDKDoc;
 }
 
 void CPDFXFA_Document::ReleaseSDKDoc() {
   if (m_pSDKDoc)

[Lei Zhang, 2015/10/02 17:21:52]

We'll need to take a pass through these as well.

     delete m_pSDKDoc;
 
   m_pSDKDoc = NULL;
 }
 
 void CPDFXFA_Document::FXRect2PDFRect(const CFX_RectF& fxRectF,
                                       CPDF_Rect& pdfRect) {
   pdfRect.left = fxRectF.left;
   pdfRect.top = fxRectF.bottom();
   pdfRect.right = fxRectF.right();
@@ skipping 764 matching lines @@
   if (pEnv == NULL)
     return FALSE;
   CFX_ByteString bs = wsLink.UTF16LE_Encode();
   int len = bs.GetLength() / sizeof(unsigned short);
   FPDF_FILEHANDLER* pFileHandler = pEnv->FFI_OpenFile(
       0, (FPDF_WIDESTRING)bs.GetBuffer(len * sizeof(unsigned short)), "rb");
   bs.ReleaseBuffer(len * sizeof(unsigned short));
 
   if (pFileHandler == NULL)
     return NULL;
-  CFPDF_FileStream* pFileRead = new CFPDF_FileStream(pFileHandler);
-  return pFileRead;
+  return new CFPDF_FileStream(pFileHandler);
 }
 FX_BOOL CPDFXFA_Document::_ExportSubmitFile(FPDF_FILEHANDLER* pFileHandler,
                                             int fileType,
                                             FPDF_DWORD encodeType,
                                             FPDF_DWORD flag) {
   if (NULL == m_pXFADocView)
     return FALSE;
   IXFA_DocHandler* pDocHandler = m_pApp->GetXFAApp()->GetDocHandler();
   CFX_ByteString content;
 
@@ skipping 329 matching lines @@
   }
 
   return _GetHValueByName(szPropName, hValue,
                           m_pSDKDoc->GetEnv()->GetJSRuntime());
 }
 FX_BOOL CPDFXFA_Document::_GetHValueByName(const CFX_ByteStringC& utf8Name,
                                            FXJSE_HVALUE hValue,
                                            IFXJS_Runtime* runTime) {
   return runTime->GetHValueByName(utf8Name, hValue);
 }