Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Issue 1377313002: Revert of Hook up ProximityAuthSystem in EasyUnlockService. (Closed)

Created:
5 years, 2 months ago by Tim Song
Modified:
5 years, 2 months ago
Reviewers:
sacomoto
CC:
chromium-reviews, scheib+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@bluetooth_connection
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Hook up ProximityAuthSystem in EasyUnlockService. (patchset #7 id:160001 of https://codereview.chromium.org/1372283002/ ) Reason for revert: MSAN test failure: http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20MSan%20Tests/builds/10082 Original issue's description: > Hook up ProximityAuthSystem in EasyUnlockService. > > ProximityAuthSystem is intended to replace the background page of the easy_unlock Chrome app. > Currently, this functionality is implemented behind the kEnableBluetoothLowEnergyDiscovery flag. > > BUG=527558 > TEST=manual > > Committed: https://crrev.com/163fa44c84f8d4041f2d2e3b2fb359f3643b03c3 > Cr-Commit-Position: refs/heads/master@{#351707} TBR=sacomoto@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=527558 Committed: https://crrev.com/7c1f91a89ddf578db224cd1874938236b93cbec8 Cr-Commit-Position: refs/heads/master@{#351721}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+260 lines, -622 lines) Patch
M chrome/browser/signin/chrome_proximity_auth_client.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/signin/easy_unlock_auth_attempt.cc View 1 chunk +9 lines, -1 line 0 comments Download
M chrome/browser/signin/easy_unlock_service.h View 5 chunks +5 lines, -20 lines 0 comments Download
M chrome/browser/signin/easy_unlock_service.cc View 8 chunks +17 lines, -32 lines 0 comments Download
M chrome/browser/signin/easy_unlock_service_regular.h View 6 chunks +3 lines, -29 lines 0 comments Download
M chrome/browser/signin/easy_unlock_service_regular.cc View 10 chunks +21 lines, -100 lines 0 comments Download
M chrome/browser/signin/easy_unlock_service_signin_chromeos.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/signin/easy_unlock_service_signin_chromeos.cc View 4 chunks +1 line, -33 lines 0 comments Download
M components/proximity_auth/cryptauth/cryptauth_device_manager.h View 1 chunk +2 lines, -2 lines 0 comments Download
M components/proximity_auth/cryptauth/cryptauth_device_manager.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M components/proximity_auth/cryptauth/cryptauth_device_manager_unittest.cc View 23 chunks +77 lines, -69 lines 0 comments Download
M components/proximity_auth/messenger_impl.h View 1 chunk +0 lines, -4 lines 0 comments Download
M components/proximity_auth/messenger_impl.cc View 6 chunks +1 line, -44 lines 0 comments Download
M components/proximity_auth/messenger_impl_unittest.cc View 2 chunks +1 line, -3 lines 0 comments Download
M components/proximity_auth/proximity_auth_system.h View 1 chunk +10 lines, -61 lines 0 comments Download
M components/proximity_auth/proximity_auth_system.cc View 1 chunk +5 lines, -101 lines 0 comments Download
M components/proximity_auth/proximity_auth_system_unittest.cc View 1 chunk +17 lines, -1 line 0 comments Download
M components/proximity_auth/proximity_monitor.h View 2 chunks +0 lines, -8 lines 0 comments Download
M components/proximity_auth/proximity_monitor_impl.h View 4 chunks +5 lines, -8 lines 0 comments Download
M components/proximity_auth/proximity_monitor_impl.cc View 4 chunks +6 lines, -15 lines 0 comments Download
M components/proximity_auth/proximity_monitor_impl_unittest.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M components/proximity_auth/remote_device_life_cycle_impl.h View 2 chunks +13 lines, -13 lines 0 comments Download
M components/proximity_auth/remote_device_life_cycle_impl.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M components/proximity_auth/remote_device_life_cycle_impl_unittest.cc View 3 chunks +3 lines, -12 lines 0 comments Download
M components/proximity_auth/screenlock_bridge.h View 1 chunk +0 lines, -1 line 0 comments Download
M components/proximity_auth/screenlock_bridge.cc View 3 chunks +1 line, -7 lines 0 comments Download
M components/proximity_auth/unlock_manager.h View 3 chunks +7 lines, -5 lines 0 comments Download
M components/proximity_auth/unlock_manager.cc View 9 chunks +21 lines, -24 lines 0 comments Download
M components/proximity_auth/unlock_manager_unittest.cc View 5 chunks +19 lines, -9 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Tim Song
Created Revert of Hook up ProximityAuthSystem in EasyUnlockService.
5 years, 2 months ago (2015-10-01 04:15:01 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1377313002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1377313002/1
5 years, 2 months ago (2015-10-01 04:15:53 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-01 04:17:18 UTC) #3
commit-bot: I haz the power
5 years, 2 months ago (2015-10-01 04:18:07 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7c1f91a89ddf578db224cd1874938236b93cbec8
Cr-Commit-Position: refs/heads/master@{#351721}

Powered by Google App Engine
This is Rietveld 408576698