Mostly-boilerplate to add MemoryMapSnapshot

snapshot/memory_map_snapshot.h

Index: snapshot/memory_map_snapshot.h
diff --git a/test/paths_win.cc b/snapshot/memory_map_snapshot.h
similarity index 55%
copy from test/paths_win.cc
copy to snapshot/memory_map_snapshot.h
index 95d0264ed82ab36cf0e541315528d44585f4bbb8..f01e11bdbaa4b58da7fceb73715682c86c0c7bef 100644
--- a/test/paths_win.cc
+++ b/snapshot/memory_map_snapshot.h
@@ -12,19 +12,27 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-#include "test/paths.h"
+#ifndef CRASHPAD_SNAPSHOT_MEMORY_MAP_SNAPSHOT_H_
+#define CRASHPAD_SNAPSHOT_MEMORY_MAP_SNAPSHOT_H_
 
 #include <windows.h>
+#include <dbghelp.h>
+
+#include <vector>
 
 namespace crashpad {
-namespace test {
 
-// static
-base::FilePath Paths::Executable() {
-  wchar_t executable_path[_MAX_PATH];
-  GetModuleFileName(nullptr, executable_path, sizeof(executable_path));
-  return base::FilePath(executable_path);
-}
+//! \brief An abstract interface to a snapshot representing the memory map of
+//!     a snapshotted process.
+class MemoryMapSnapshot {
+ public:
+  virtual ~MemoryMapSnapshot() {}
+
+  //! \brief A vector of `MINIDUMP_MEMORY_INFO` objects describing the regions
+  //!     of the memory map.
+  virtual const std::vector<MINIDUMP_MEMORY_INFO>& Regions() const = 0;

[Mark Mentovai, 2015/10/06 20:44:49]

Is there a need for any other member functions in this interface? If not, we may
as well do away with MemoryMapSnapshot, and just add std::vector<Type>
ProcessSnapshot::MemoryMapRegions(), the same way that it deals with vectors of
modules and threads.

I can’t really think of anything that might need to be a property of the memory
map that’s not a region, and any hypothetical thing that could go here would
probably also also make sense as an attribute of ProcessSnapshot.

[scottmg, 2015/10/07 21:45:09]

I thought there might be when I started, but I can't think of anything either.
Done.

+};
 
-}  // namespace test
 }  // namespace crashpad
+
+#endif  // CRASHPAD_SNAPSHOT_MEMORY_MAP_SNAPSHOT_H_