Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(455)

Unified Diff: snapshot/win/memory_map_snapshot_win.cc

Issue 1377133006: Mostly-boilerplate to add MemoryMapSnapshot (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@memory-info-to-misc
Patch Set: . Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: snapshot/win/memory_map_snapshot_win.cc
diff --git a/util/file/file_seeker.cc b/snapshot/win/memory_map_snapshot_win.cc
similarity index 57%
copy from util/file/file_seeker.cc
copy to snapshot/win/memory_map_snapshot_win.cc
index a38e2f918546e955a1e114215907c35f3820a230..749d2d4e4e1010e6bb6e04f05a7a1a17faaa724d 100644
--- a/util/file/file_seeker.cc
+++ b/snapshot/win/memory_map_snapshot_win.cc
@@ -12,26 +12,26 @@
// See the License for the specific language governing permissions and
// limitations under the License.
-#include "util/file/file_seeker.h"
+#include "snapshot/win/memory_map_snapshot_win.h"
-#include "base/logging.h"
+#include "snapshot/win/process_reader_win.h"
namespace crashpad {
+namespace internal {
-FileOffset FileSeekerInterface::SeekGet() {
- return Seek(0, SEEK_CUR);
+MemoryMapSnapshotWin::MemoryMapSnapshotWin() : regions_() {
}
-bool FileSeekerInterface::SeekSet(FileOffset offset) {
- FileOffset rv = Seek(offset, SEEK_SET);
- if (rv < 0) {
- // Seek() will have logged its own error.
- return false;
- } else if (rv != offset) {
- LOG(ERROR) << "SeekSet(): expected " << offset << ", observed " << rv;
- return false;
- }
- return true;
+MemoryMapSnapshotWin::~MemoryMapSnapshotWin() {
}
+void MemoryMapSnapshotWin::Initialize(ProcessReaderWin* process_reader) {
+ regions_ = process_reader->GetProcessInfo().MemoryInfo();
Mark Mentovai 2015/10/06 20:44:49 The types are getting confused here. (Or is this f
scottmg 2015/10/07 21:45:09 This is gone now.
+}
+
+const std::vector<MINIDUMP_MEMORY_INFO>& MemoryMapSnapshotWin::Regions() const {
+ return regions_;
+}
+
+} // namespace internal
} // namespace crashpad

Powered by Google App Engine
This is Rietveld 408576698