snapshot/mac/process_snapshot_mac.cc - Issue 1377133006: Mostly-boilerplate to add MemoryMapSnapshot

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: snapshot/mac/process_snapshot_mac.cc

Issue 1377133006: Mostly-boilerplate to add MemoryMapSnapshot (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@memory-info-to-misc

Patch Set: . Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: snapshot/mac/process_snapshot_mac.cc

diff --git a/snapshot/mac/process_snapshot_mac.cc b/snapshot/mac/process_snapshot_mac.cc

index 7560317a4cab6fd13908c633594a750811bd85ff..17edc717208f2d82cf82a91f780b5f93cf87e9ba 100644

--- a/snapshot/mac/process_snapshot_mac.cc

+++ b/snapshot/mac/process_snapshot_mac.cc

@@ -186,6 +186,11 @@ const ExceptionSnapshot* ProcessSnapshotMac::Exception() const {

return exception_.get();

}

+const MemoryMapSnapshot* ProcessSnapshotMac::MemoryMap() const {

+ INITIALIZATION_STATE_DCHECK_VALID(initialized_);

+ return nullptr;

std::vector<const MemorySnapshot*> ProcessSnapshotMac::ExtraMemory() const {

INITIALIZATION_STATE_DCHECK_VALID(initialized_);

return std::vector<const MemorySnapshot*>();

« compat/non_win/dbghelp.h ('K') | « snapshot/mac/process_snapshot_mac.h ('k') | snapshot/memory_map_snapshot.h » ('j') | snapshot/memory_map_snapshot.h » ('J')