Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 137653003: Do not tell people to ask me for help. I won't help them. (Closed)

Created:
6 years, 11 months ago by M-A Ruel
Modified:
6 years, 11 months ago
Reviewers:
iannucci
CC:
chromium-reviews, cmp-cc_chromium.org, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org
Visibility:
Public.

Description

Do not tell people to ask me for help. I won't help them. Write a small HowTo to help confused people by confusing checks. R=iannucci@chromium.org BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244717

Patch Set 1 #

Total comments: 2

Patch Set 2 : english his hard #

Patch Set 3 : english his hard #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -9 lines) Patch
presubmit_support.py View 1 1 chunk +4 lines, -2 lines 0 comments Download
tests/presubmit_unittest.py View 1 1 chunk +9 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
M-A Ruel
6 years, 11 months ago (2014-01-14 02:15:30 UTC) #1
iannucci
lgtm % english :) https://codereview.chromium.org/137653003/diff/1/presubmit_support.py File presubmit_support.py (right): https://codereview.chromium.org/137653003/diff/1/presubmit_support.py#newcode1306 presubmit_support.py:1306: 'to figure out the PRESUBMIT.py ...
6 years, 11 months ago (2014-01-14 02:38:39 UTC) #2
Dirk Pranke
I would be tempted to delete this message altogether. I've almost never seen a case ...
6 years, 11 months ago (2014-01-14 03:11:01 UTC) #3
M-A Ruel
I'll commit manually because Rietveld HTTP 500s while uploading. On 2014/01/14 03:11:01, Dirk Pranke wrote: ...
6 years, 11 months ago (2014-01-14 15:19:50 UTC) #4
M-A Ruel
6 years, 11 months ago (2014-01-14 15:23:03 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 manually as r244717.

Powered by Google App Engine
This is Rietveld 408576698