Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Unified Diff: tests/presubmit_unittest.py

Issue 137653003: Do not tell people to ask me for help. I won't help them. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools
Patch Set: english his hard Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « presubmit_support.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/presubmit_unittest.py
diff --git a/tests/presubmit_unittest.py b/tests/presubmit_unittest.py
index 7d5838053970fc236cf44df4cc929100f7a15725..d0d3ab4e3edc548670f9b5d31e5544c55ee06e85 100755
--- a/tests/presubmit_unittest.py
+++ b/tests/presubmit_unittest.py
@@ -815,13 +815,15 @@ def CheckChangeOnCommit(input_api, output_api):
output = presubmit.DoPresubmitChecks(
change, False, True, None, input_buf, DEFAULT_SCRIPT, False, None)
self.failIf(output.should_continue())
- text = ('Running presubmit upload checks ...\n'
- 'Warning, no PRESUBMIT.py found.\n'
- 'Running default presubmit script.\n'
- '\n'
- '** Presubmit ERRORS **\n!!\n\n'
- 'Was the presubmit check useful? Please send feedback & hate mail '
- 'to maruel@chromium.org!\n')
+ text = (
+ 'Running presubmit upload checks ...\n'
+ 'Warning, no PRESUBMIT.py found.\n'
+ 'Running default presubmit script.\n'
+ '\n'
+ '** Presubmit ERRORS **\n!!\n\n'
+ 'Was the presubmit check useful? If not, run "git cl presubmit -v"\n'
+ 'to figure out which PRESUBMIT.py was run, then run git blame\n'
+ 'on the file to figure out who to ask for help.\n')
self.assertEquals(output.getvalue(), text)
def testDirectoryHandling(self):
« no previous file with comments | « presubmit_support.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698