presubmit_support.py - Issue 137653003: Do not tell people to ask me for help. I won't help them.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: presubmit_support.py

Issue 137653003: Do not tell people to ask me for help. I won't help them. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Patch Set: english his hard Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: presubmit_support.py

diff --git a/presubmit_support.py b/presubmit_support.py

index d22c9c07296278de38fd2d01a23d304986b0fe15..dabfbf0bac2e7bbf253aaa29245fca5378ed58eb 100755

--- a/presubmit_support.py

+++ b/presubmit_support.py

@@ -1301,8 +1301,10 @@ def DoPresubmitChecks(change,

global _ASKED_FOR_FEEDBACK

# Ask for feedback one time out of 5.

if (len(results) and random.randint(0, 4) == 0 and not _ASKED_FOR_FEEDBACK):

- output.write("Was the presubmit check useful? Please send feedback "

- "& hate mail to maruel@chromium.org!\n")

+ output.write(

+ 'Was the presubmit check useful? If not, run "git cl presubmit -v"\n'

+ 'to figure out which PRESUBMIT.py was run, then run git blame\n'

+ 'on the file to figure out who to ask for help.\n')

_ASKED_FOR_FEEDBACK = True

return output

finally:

« no previous file with comments | « no previous file | tests/presubmit_unittest.py » ('j') | no next file with comments »