Issue 137643003: Temporary fix for telemetry builds

Issue 137643003: Temporary fix for telemetry builds (Closed)

Created:
6 years, 11 months ago by Cait (Slow)

Modified:
6 years, 11 months ago

Reviewers:
csharp, scottmg

CC:
chromium-reviews, scottmg

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Temporary fix for telemetry builds Until we get the swapimport tool up and running on x64 builds of Windows. BUG=335945, 336025 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245928

Patch Set 2 : use target_arch instead #

Total comments: 1

Patch Set 3 : Python cleanup #

Total comments: 1

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -10 lines)			Patch
	M	build/win/reorder-imports.py	View	1 2	2 chunks	+18 lines, -10 lines	1 comment	Download
	M	chrome/chrome_exe.gypi	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

Cait (Slow)

csharp: PTAL. quick (temporary) fix to the script that calls swapimport, to make sure that ...

6 years, 11 months ago (2014-01-19 22:27:30 UTC) #1

scottmg

https://codereview.chromium.org/137643003/diff/1/build/win/reorder-imports.py File build/win/reorder-imports.py (right): https://codereview.chromium.org/137643003/diff/1/build/win/reorder-imports.py#newcode23 build/win/reorder-imports.py:23: if platform.architecture()[0] == '64bit': I don't thing this will ...

6 years, 11 months ago (2014-01-19 22:33:33 UTC) #2

scottmg

lgtm https://codereview.chromium.org/137643003/diff/50001/build/win/reorder-imports.py File build/win/reorder-imports.py (right): https://codereview.chromium.org/137643003/diff/50001/build/win/reorder-imports.py#newcode49 build/win/reorder-imports.py:49: return reorder_imports(opts.input, opts.output, opts.arch) i think this will ...

6 years, 11 months ago (2014-01-20 01:23:22 UTC) #4

csharp

lgtm with nit https://codereview.chromium.org/137643003/diff/110001/build/win/reorder-imports.py File build/win/reorder-imports.py (right): https://codereview.chromium.org/137643003/diff/110001/build/win/reorder-imports.py#newcode30 build/win/reorder-imports.py:30: [swap_exe, '--input-image=%s' % input_image, Nit: You ...

6 years, 11 months ago (2014-01-20 14:35:39 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/caitkp@chromium.org/137643003/110001

6 years, 11 months ago (2014-01-20 14:52:41 UTC) #7

Message was sent while issue was closed.

Change committed as 245928

Expand Messages | Collapse Messages