Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Unified Diff: build/win/reorder-imports.py

Issue 137643003: Temporary fix for telemetry builds (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Python cleanup Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/chrome_exe.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/win/reorder-imports.py
diff --git a/build/win/reorder-imports.py b/build/win/reorder-imports.py
index d320b51e9e7cc6d39445ef06fabd753375839e29..da0a09a353e9d0872067001b8e6932a4f55ecf18 100755
--- a/build/win/reorder-imports.py
+++ b/build/win/reorder-imports.py
@@ -10,19 +10,25 @@ import shutil
import subprocess
import sys
-def reorder_imports(input_dir, output_dir):
+def reorder_imports(input_dir, output_dir, architecture):
"""Run swapimports.exe on the initial chrome.exe, and write to the output
directory. Also copy over any related files that might be needed
(pdbs, manifests etc.).
"""
- input_image = '--input-image=%s' % (os.path.join(input_dir, 'chrome.exe'))
- output_image = '--output-image=%s' % (os.path.join(output_dir, 'chrome.exe'))
- swap_exe = os.path.join(
- __file__,
- '..\\..\\..\\third_party\\syzygy\\binaries\\exe\\swapimport.exe')
- subprocess.call(
- [swap_exe, input_image, output_image, '--overwrite', 'chrome_elf.dll'])
+ input_image = os.path.join(input_dir, 'chrome.exe')
+ output_image = os.path.join(output_dir, 'chrome.exe')
+
+ # TODO(caitkp): Remove this once swapimport works on x64 builds.
+ if architecture == 'x64':
+ shutil.copy(input_image, output_image)
+ else:
+ swap_exe = os.path.join(
+ __file__,
+ '..\\..\\..\\third_party\\syzygy\\binaries\\exe\\swapimport.exe')
+ subprocess.call(
+ [swap_exe, '--input-image=%s' % input_image,
csharp 2014/01/20 14:35:39 Nit: You can just have "'--input-image', input_ima
+ '--output-image=%s' % output_image, '--overwrite', 'chrome_elf.dll'])
for fname in glob.iglob(os.path.join(input_dir, 'chrome.exe.*')):
shutil.copy(fname, os.path.join(output_dir, os.path.basename(fname)))
@@ -30,17 +36,19 @@ def reorder_imports(input_dir, output_dir):
def main(argv):
- usage = 'reorder_imports.py -i <input_dir> -o <output_dir>'
+ usage = 'reorder_imports.py -i <input_dir> -o <output_dir> -a <target_arch>'
parser = optparse.OptionParser(usage=usage)
parser.add_option('-i', '--input', help='reorder chrome.exe in DIR',
metavar='DIR')
parser.add_option('-o', '--output', help='write new chrome.exe to DIR',
metavar='DIR')
+ parser.add_option('-a', '--arch', help='architecture of build (optional)',
+ default='ia32')
opts, args = parser.parse_args()
if not opts.input or not opts.output:
parser.error('Please provide and input and output directory')
- return reorder_imports(opts.input, opts.output)
+ return reorder_imports(opts.input, opts.output, opts.arch)
if __name__ == "__main__":
sys.exit(main(sys.argv[1:]))
« no previous file with comments | « no previous file | chrome/chrome_exe.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698