Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 #!/usr/bin/env python | 1 #!/usr/bin/env python |
| 2 # Copyright 2014 The Chromium Authors. All rights reserved. | 2 # Copyright 2014 The Chromium Authors. All rights reserved. |
| 3 # Use of this source code is governed by a BSD-style license that can be | 3 # Use of this source code is governed by a BSD-style license that can be |
| 4 # found in the LICENSE file. | 4 # found in the LICENSE file. |
| 5 | 5 |
| 6 import glob | 6 import glob |
| 7 import optparse | 7 import optparse |
| 8 import os | 8 import os |
| 9 import shutil | 9 import shutil |
| 10 import subprocess | 10 import subprocess |
| 11 import sys | 11 import sys |
| 12 | 12 |
| 13 def reorder_imports(input_dir, output_dir): | 13 def reorder_imports(input_dir, output_dir, architecture): |
| 14 """Run swapimports.exe on the initial chrome.exe, and write to the output | 14 """Run swapimports.exe on the initial chrome.exe, and write to the output |
| 15 directory. Also copy over any related files that might be needed | 15 directory. Also copy over any related files that might be needed |
| 16 (pdbs, manifests etc.). | 16 (pdbs, manifests etc.). |
| 17 """ | 17 """ |
| 18 input_image = '--input-image=%s' % (os.path.join(input_dir, 'chrome.exe')) | |
| 19 output_image = '--output-image=%s' % (os.path.join(output_dir, 'chrome.exe')) | |
| 20 | 18 |
| 21 swap_exe = os.path.join( | 19 input_image = os.path.join(input_dir, 'chrome.exe') |
| 22 __file__, | 20 output_image = os.path.join(output_dir, 'chrome.exe') |
| 23 '..\\..\\..\\third_party\\syzygy\\binaries\\exe\\swapimport.exe') | 21 |
| 24 subprocess.call( | 22 # TODO(caitkp): Remove this once swapimport works on x64 builds. |
| 25 [swap_exe, input_image, output_image, '--overwrite', 'chrome_elf.dll']) | 23 if architecture == 'x64': |
| 24 shutil.copy(input_image, output_image) | |
| 25 else: | |
| 26 swap_exe = os.path.join( | |
| 27 __file__, | |
| 28 '..\\..\\..\\third_party\\syzygy\\binaries\\exe\\swapimport.exe') | |
| 29 subprocess.call( | |
| 30 [swap_exe, '--input-image=%s' % input_image, | |
|
csharp
2014/01/20 14:35:39
Nit: You can just have "'--input-image', input_ima
| |
| 31 '--output-image=%s' % output_image, '--overwrite', 'chrome_elf.dll']) | |
| 26 | 32 |
| 27 for fname in glob.iglob(os.path.join(input_dir, 'chrome.exe.*')): | 33 for fname in glob.iglob(os.path.join(input_dir, 'chrome.exe.*')): |
| 28 shutil.copy(fname, os.path.join(output_dir, os.path.basename(fname))) | 34 shutil.copy(fname, os.path.join(output_dir, os.path.basename(fname))) |
| 29 return 0 | 35 return 0 |
| 30 | 36 |
| 31 | 37 |
| 32 def main(argv): | 38 def main(argv): |
| 33 usage = 'reorder_imports.py -i <input_dir> -o <output_dir>' | 39 usage = 'reorder_imports.py -i <input_dir> -o <output_dir> -a <target_arch>' |
| 34 parser = optparse.OptionParser(usage=usage) | 40 parser = optparse.OptionParser(usage=usage) |
| 35 parser.add_option('-i', '--input', help='reorder chrome.exe in DIR', | 41 parser.add_option('-i', '--input', help='reorder chrome.exe in DIR', |
| 36 metavar='DIR') | 42 metavar='DIR') |
| 37 parser.add_option('-o', '--output', help='write new chrome.exe to DIR', | 43 parser.add_option('-o', '--output', help='write new chrome.exe to DIR', |
| 38 metavar='DIR') | 44 metavar='DIR') |
| 45 parser.add_option('-a', '--arch', help='architecture of build (optional)', | |
| 46 default='ia32') | |
| 39 opts, args = parser.parse_args() | 47 opts, args = parser.parse_args() |
| 40 | 48 |
| 41 if not opts.input or not opts.output: | 49 if not opts.input or not opts.output: |
| 42 parser.error('Please provide and input and output directory') | 50 parser.error('Please provide and input and output directory') |
| 43 return reorder_imports(opts.input, opts.output) | 51 return reorder_imports(opts.input, opts.output, opts.arch) |
| 44 | 52 |
| 45 if __name__ == "__main__": | 53 if __name__ == "__main__": |
| 46 sys.exit(main(sys.argv[1:])) | 54 sys.exit(main(sys.argv[1:])) |
| OLD | NEW |