Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1375353004: Add TextRun object to nvpr text (Closed)

Created:
5 years, 2 months ago by Chris Dalton
Modified:
5 years, 2 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@upload1_simplify
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add TextRun object to nvpr text Adds a TextRun object that defines a resolution-independent, paint- indepent draw for a string of nvpr text. BUG=skia: Committed: https://skia.googlesource.com/skia/+/3bd909a44c46976e81d806dcaf69dbf0bbbb8501

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+178 lines, -188 lines) Patch
M src/gpu/GrStencilAndCoverTextContext.h View 3 chunks +31 lines, -25 lines 0 comments Download
M src/gpu/GrStencilAndCoverTextContext.cpp View 10 chunks +147 lines, -163 lines 0 comments Download

Depends on Patchset:

Issue 1380973002 Patch 1

Dependent Patchsets:

Issue 1381873003 Patch 1
Issue 1381873003 Patch 20001

Messages

Total messages: 9 (3 generated)
Chris Dalton
5 years, 2 months ago (2015-10-01 04:47:46 UTC) #2
Chris Dalton
5 years, 2 months ago (2015-10-01 04:48:29 UTC) #3
Mark Kilgard
not a well-qualified reviewer for this, but see no issues
5 years, 2 months ago (2015-10-01 17:38:24 UTC) #5
bsalomon
lgtm
5 years, 2 months ago (2015-10-02 13:39:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1375353004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1375353004/1
5 years, 2 months ago (2015-10-05 21:50:59 UTC) #8
commit-bot: I haz the power
5 years, 2 months ago (2015-10-05 21:57:26 UTC) #9
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/3bd909a44c46976e81d806dcaf69dbf0bbbb8501

Powered by Google App Engine
This is Rietveld 408576698