Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1381873003: Use SkTextBlob for nvpr color bitmap fallbacks (Closed)

Created:
5 years, 2 months ago by Chris Dalton
Modified:
5 years, 2 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@upload2_textrun
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Use SkTextBlob for nvpr color bitmap fallbacks BUG=skia: Committed: https://skia.googlesource.com/skia/+/02015e51d90597e13525d46aa1757f34fc19307b

Patch Set 1 #

Patch Set 2 : Fix msvc build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -30 lines) Patch
M src/gpu/GrStencilAndCoverTextContext.h View 3 chunks +4 lines, -3 lines 0 comments Download
M src/gpu/GrStencilAndCoverTextContext.cpp View 1 6 chunks +94 lines, -27 lines 0 comments Download

Depends on Patchset:

Issue 1375353004 Patch 1

Messages

Total messages: 13 (6 generated)
Chris Dalton
5 years, 2 months ago (2015-10-01 04:49:53 UTC) #2
Mark Kilgard
not a well-qualified reviewer, but see no issues
5 years, 2 months ago (2015-10-01 17:40:00 UTC) #4
bsalomon
lgtm
5 years, 2 months ago (2015-10-02 13:47:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1381873003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1381873003/1
5 years, 2 months ago (2015-10-05 22:16:48 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win-MSVC-x86-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-Debug-Trybot/builds/3560) Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, ...
5 years, 2 months ago (2015-10-05 22:18:50 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1381873003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1381873003/20001
5 years, 2 months ago (2015-10-05 22:21:49 UTC) #12
commit-bot: I haz the power
5 years, 2 months ago (2015-10-05 22:28:26 UTC) #13
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/02015e51d90597e13525d46aa1757f34fc19307b

Powered by Google App Engine
This is Rietveld 408576698