Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Issue 1380973002: Simplify nvpr text (Closed)

Created:
5 years, 2 months ago by Chris Dalton
Modified:
5 years, 2 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Simplify nvpr text - Drops device-space glyphs in favor of perf/simplicity. - Removes residual complexities that would flip glyphs vertically for compatibility with nvpr glyph loading, which is no longer used. - Drops hairline support since they required new paths for every draw matrix, and could only be supported under certain circumstances. - Quits checking for color bitmap fonts in canDrawText since the normal color emoji fallback will handle them anyway. BUG=skia: Committed: https://skia.googlesource.com/skia/+/7d5c950e85b4766a05ed834c594033c9dd6913cb

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove accidental SampleApp hack #

Patch Set 3 : Remove accidental SampleApp hack #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -230 lines) Patch
M src/gpu/GrPathRendering.cpp View 3 chunks +1 line, -5 lines 0 comments Download
M src/gpu/GrStencilAndCoverTextContext.h View 2 3 chunks +2 lines, -27 lines 0 comments Download
M src/gpu/GrStencilAndCoverTextContext.cpp View 2 8 chunks +69 lines, -198 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
Chris Dalton
I'm curious how you guys feel about this. I like getting drawText and drawPosText to ...
5 years, 2 months ago (2015-10-01 04:46:43 UTC) #2
Mark Kilgard
lgtm mostly clean up, eliminating code https://chromiumcodereview.appspot.com/1380973002/diff/1/samplecode/SampleApp.cpp File samplecode/SampleApp.cpp (right): https://chromiumcodereview.appspot.com/1380973002/diff/1/samplecode/SampleApp.cpp#newcode246 samplecode/SampleApp.cpp:246: fCurIntf = SkRef/*GrGLInterfaceRemoveNVPR*/(glInterface.get()); ...
5 years, 2 months ago (2015-10-01 17:33:25 UTC) #4
bsalomon
lgtm
5 years, 2 months ago (2015-10-02 13:22:07 UTC) #5
Chris Dalton
https://codereview.chromium.org/1380973002/diff/1/samplecode/SampleApp.cpp File samplecode/SampleApp.cpp (right): https://codereview.chromium.org/1380973002/diff/1/samplecode/SampleApp.cpp#newcode246 samplecode/SampleApp.cpp:246: fCurIntf = SkRef/*GrGLInterfaceRemoveNVPR*/(glInterface.get()); On 2015/10/01 17:33:24, Mark Kilgard wrote: ...
5 years, 2 months ago (2015-10-03 16:39:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1380973002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1380973002/40001
5 years, 2 months ago (2015-10-03 16:57:10 UTC) #9
commit-bot: I haz the power
The author cdalton@nvidia.com has not signed Google Contributor License Agreement. Please visit https://cla.developers.google.com to sign ...
5 years, 2 months ago (2015-10-03 16:57:12 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1380973002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1380973002/40001
5 years, 2 months ago (2015-10-03 20:21:51 UTC) #13
commit-bot: I haz the power
5 years, 2 months ago (2015-10-03 20:28:42 UTC) #14
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/7d5c950e85b4766a05ed834c594033c9dd6913cb

Powered by Google App Engine
This is Rietveld 408576698