Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1374553002: Add an uber page browser test for WebUI URL logging. (Closed)

Created:
5 years, 2 months ago by Dan Beam
Modified:
5 years, 2 months ago
Reviewers:
Charlie Reis
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@webui-log
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add an uber page browser test for WebUI URL logging. BUG=535059, 385352 R=creis@chromium.org Committed: https://crrev.com/1f3b25c8d78be73787d4d4c577d2f5e9f826ab46 Cr-Commit-Position: refs/heads/master@{#351241}

Patch Set 1 #

Patch Set 2 : histogram_tester #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -1 line) Patch
M chrome/browser/ui/webui/log_web_ui_url_browsertest.cc View 1 2 chunks +56 lines, -1 line 0 comments Download

Depends on Patchset:

Issue 1367343002 Patch 90001

Messages

Total messages: 8 (1 generated)
Dan Beam
5 years, 2 months ago (2015-09-28 05:49:14 UTC) #1
Charlie Reis
Same note about HistogramTester. (And thanks for following up with tests!)
5 years, 2 months ago (2015-09-28 20:40:08 UTC) #2
Dan Beam
On 2015/09/28 20:40:08, Charlie Reis wrote: > Same note about HistogramTester. (And thanks for following ...
5 years, 2 months ago (2015-09-28 21:47:51 UTC) #3
Charlie Reis
LGTM
5 years, 2 months ago (2015-09-28 21:58:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1374553002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1374553002/20001
5 years, 2 months ago (2015-09-29 01:55:51 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-09-29 02:27:15 UTC) #7
commit-bot: I haz the power
5 years, 2 months ago (2015-09-29 02:28:39 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/1f3b25c8d78be73787d4d4c577d2f5e9f826ab46
Cr-Commit-Position: refs/heads/master@{#351241}

Powered by Google App Engine
This is Rietveld 408576698