Add browser test for WebUI URL logging

Add browser test for WebUI URL logging

R=creis@chromium.org
BUG=535059, 385352
Committed: https://crrev.com/03d3d97dcb17d50824e5b1df7b25554dc3c0d903
Cr-Commit-Position: refs/heads/master@{#351191}

[Dan Beam, 2015-09-26 22:58:41]

Patchset #1 (id:1) has been deleted

[Dan Beam, 2015-09-26 22:59:05]

Patchset #1 (id:20001) has been deleted

[Dan Beam, 2015-09-26 23:02:14]

https://codereview.chromium.org/1367343002/diff/40001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/log_web_ui_url.cc (right):

https://codereview.chromium.org/1367343002/diff/40001/chrome/browser/ui/webui...
chrome/browser/ui/webui/log_web_ui_url.cc:24: static WebUIUrlHash* g_hash =
nullptr;
if you have any suggestions that don't require this g_* pointer and manual
delete to allow tests to spy here, I'm all ears.

note: this needs to be changed for the chrome/ level, not just content/, afaik
(otherwise I'd just call SetContentBrowserClientForTesting() or whatever)

https://codereview.chromium.org/1367343002/diff/40001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/log_web_ui_url.h (right):

https://codereview.chromium.org/1367343002/diff/40001/chrome/browser/ui/webui...
chrome/browser/ui/webui/log_web_ui_url.h:8: #include "base/callback.h"
callback_forward wasn't working for me

[Dan Beam, 2015-09-28 05:44:42]

Patchset #2 (id:50001) has been deleted

[Charlie Reis, 2015-09-28 20:39:05]

creis@chromium.org changed reviewers:
+ nick@chromium.org

[Charlie Reis, 2015-09-28 20:39:05]

I think you can test the UMA values directly using HistogramTester, without
needing to mock the hash function.

I just learned this recently, when Nick added tests like
SiteDetailsBrowserTest.ManyIframes (see site_details_browsertest.cc).  The
pattern is something like:

  EXPECT_THAT(details->uma()->GetAllSamples(
                  "SiteIsolation.CurrentRendererProcessCount"),
              ElementsAre(Bucket(1, 1)));

There's some good docs in histogram_tester.h.

[Dan Beam, 2015-09-28 21:33:13]

On 2015/09/28 20:39:05, Charlie Reis wrote:
> I think you can test the UMA values directly using HistogramTester, without
> needing to mock the hash function.
> 
> I just learned this recently, when Nick added tests like
> SiteDetailsBrowserTest.ManyIframes (see site_details_browsertest.cc).  The
> pattern is something like:
> 
>   EXPECT_THAT(details->uma()->GetAllSamples(
>                   "SiteIsolation.CurrentRendererProcessCount"),
>               ElementsAre(Bucket(1, 1)));
> 
> There's some good docs in histogram_tester.h.

Done.

[Charlie Reis, 2015-09-28 21:58:14]

Nice.  LGTM.

[Dan Beam, 2015-09-28 22:43:32]

The CQ bit was checked by dbeam@chromium.org

[commit-bot: I haz the power, 2015-09-28 22:44:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1367343002/90001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1367343002/90001

[commit-bot: I haz the power, 2015-09-28 22:51:25]

Committed patchset #3 (id:90001)

[commit-bot: I haz the power, 2015-09-28 22:52:35]

Patchset 3 (id:??) landed as
https://crrev.com/03d3d97dcb17d50824e5b1df7b25554dc3c0d903
Cr-Commit-Position: refs/heads/master@{#351191}