Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Unified Diff: chrome/browser/ui/webui/log_web_ui_url_browsertest.cc

Issue 1374553002: Add an uber page browser test for WebUI URL logging. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@webui-log
Patch Set: histogram_tester Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/log_web_ui_url_browsertest.cc
diff --git a/chrome/browser/ui/webui/log_web_ui_url_browsertest.cc b/chrome/browser/ui/webui/log_web_ui_url_browsertest.cc
index eaa593e9ea7bb6ad022c17fcddef9ee7580d2e28..20bed1fac42ffa5ef241330b7e59414eb6ac6bed 100644
--- a/chrome/browser/ui/webui/log_web_ui_url_browsertest.cc
+++ b/chrome/browser/ui/webui/log_web_ui_url_browsertest.cc
@@ -10,10 +10,15 @@
#include "base/test/histogram_tester.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/browser_commands.h"
+#include "chrome/browser/ui/tabs/tab_strip_model.h"
#include "chrome/common/url_constants.h"
#include "chrome/test/base/in_process_browser_test.h"
#include "chrome/test/base/ui_test_utils.h"
+#include "content/public/common/url_constants.h"
+#include "content/public/test/browser_test_utils.h"
+#include "grit/generated_resources.h"
#include "testing/gmock/include/gmock/gmock.h"
+#include "ui/base/l10n/l10n_util.h"
#include "url/gurl.h"
using base::Bucket;
@@ -49,6 +54,56 @@ IN_PROC_BROWSER_TEST_F(LogWebUIUrlTest, TestHistoryFrame) {
EXPECT_THAT(GetSamples(), ElementsAre(Bucket(history_frame_url_hash, 2)));
}
-// TODO(dbeam): test an uber page URL like chrome://history.
+#if defined(ENABLE_EXTENSIONS)
+IN_PROC_BROWSER_TEST_F(LogWebUIUrlTest, TestUberPage) {
+ content::WebContents* tab =
+ browser()->tab_strip_model()->GetActiveWebContents();
+
+ base::string16 history_title = l10n_util::GetStringUTF16(IDS_HISTORY_TITLE);
+
+ {
+ content::TitleWatcher title_watcher(tab, history_title);
+ ui_test_utils::NavigateToURL(browser(), GURL(chrome::kChromeUIHistoryURL));
+ ASSERT_EQ(history_title, title_watcher.WaitAndGetTitle());
+ }
+
+ std::string scheme(content::kChromeUIScheme);
+ GURL uber_url(scheme + "://" + chrome::kChromeUIUberHost);
+ uint32 uber_url_hash = base::Hash(uber_url.spec());
+
+ GURL history_frame_url(chrome::kChromeUIHistoryFrameURL);
+ uint32 history_frame_url_hash = base::Hash(history_frame_url.spec());
+
+ EXPECT_THAT(GetSamples(), ElementsAre(Bucket(history_frame_url_hash, 1),
+ Bucket(uber_url_hash, 1)));
+
+ {
+ content::TitleWatcher title_watcher(tab, history_title);
+ chrome::Reload(browser(), CURRENT_TAB);
+ ASSERT_EQ(history_title, title_watcher.WaitAndGetTitle());
+ }
+
+ EXPECT_THAT(GetSamples(), ElementsAre(Bucket(history_frame_url_hash, 2),
+ Bucket(uber_url_hash, 2)));
+
+ {
+ // Pretend a user clicked on "Extensions".
+ base::string16 extensions_title =
+ l10n_util::GetStringUTF16(IDS_MANAGE_EXTENSIONS_SETTING_WINDOWS_TITLE);
+ content::TitleWatcher title_watcher(tab, extensions_title);
+ std::string javascript =
+ "uber.invokeMethodOnWindow(window, 'showPage', {pageId: 'extensions'})";
+ ASSERT_TRUE(content::ExecuteScript(tab, javascript));
+ ASSERT_EQ(extensions_title, title_watcher.WaitAndGetTitle());
+ }
+
+ GURL extensions_frame_url(chrome::kChromeUIExtensionsFrameURL);
+ uint32 extensions_frame_url_hash = base::Hash(extensions_frame_url.spec());
+
+ EXPECT_THAT(GetSamples(), ElementsAre(Bucket(extensions_frame_url_hash, 1),
+ Bucket(history_frame_url_hash, 2),
+ Bucket(uber_url_hash, 2)));
+}
+#endif
} // namespace webui
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698