Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 1374543004: Revert of Disable support for swapped out RenderFrame(Host) on desktop. (Closed)

Created:
5 years, 2 months ago by zhaoqin1
Modified:
5 years, 2 months ago
Reviewers:
Charlie Reis, nasko
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Disable support for swapped out RenderFrame(Host) on desktop. (patchset #16 id:300001 of https://codereview.chromium.org/1199313006/ ) Reason for revert: This CL is the culprit of RenderFrameHostManagerTest.NoScriptAccessAfterSwapOut content_browsertests failure on TSan bots BUG=537689 Original issue's description: > Disable support for swapped out RenderFrame(Host) on desktop. > > This CL disables the usage of swapped out RenderFrame(Host) objects. Instead > RenderFrameProxy(Host) is used. Disabling is done through setting a > boolean value in checking for swapped out support and the actual code > will be removed in follow up CLs, once this one sticks and no issues are found. > > Android is left alone, as troubleshooting why content_browsertests is failing > on the bots is very time consuming. Follow up patch will disable it there too. > > BUG=357747 > > Committed: https://crrev.com/b8cc9ba3b9d0b8478bfd5d63130dfcfc69fbe6e6 > Cr-Commit-Position: refs/heads/master@{#351446} TBR=creis@chromium.org,nasko@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=357747 Committed: https://crrev.com/e8a98e91d731af4c74f7e933727517fa2b924f87 Cr-Commit-Position: refs/heads/master@{#351597}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M content/common/site_isolation_policy.cc View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
zhaoqin1
Created Revert of Disable support for swapped out RenderFrame(Host) on desktop.
5 years, 2 months ago (2015-09-30 18:09:22 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1374543004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1374543004/1
5 years, 2 months ago (2015-09-30 18:11:52 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-30 18:13:58 UTC) #3
commit-bot: I haz the power
5 years, 2 months ago (2015-09-30 18:14:53 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e8a98e91d731af4c74f7e933727517fa2b924f87
Cr-Commit-Position: refs/heads/master@{#351597}

Powered by Google App Engine
This is Rietveld 408576698