Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 1199313006: Disable support for swapped out RenderFrame(Host) on desktop. (Closed)

Created:
5 years, 6 months ago by nasko
Modified:
5 years, 2 months ago
Reviewers:
Charlie Reis
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable support for swapped out RenderFrame(Host) on desktop. This CL disables the usage of swapped out RenderFrame(Host) objects. Instead RenderFrameProxy(Host) is used. Disabling is done through setting a boolean value in checking for swapped out support and the actual code will be removed in follow up CLs, once this one sticks and no issues are found. Android is left alone, as troubleshooting why content_browsertests is failing on the bots is very time consuming. Follow up patch will disable it there too. BUG=357747 Committed: https://crrev.com/b8cc9ba3b9d0b8478bfd5d63130dfcfc69fbe6e6 Cr-Commit-Position: refs/heads/master@{#351446}

Patch Set 1 #

Total comments: 3

Patch Set 2 : Rebased on ToT. #

Patch Set 3 : Flip the swapped out forbidden flag. #

Patch Set 4 : Fixing some webview/mime_handler_view cases. #

Patch Set 5 : Rebase on ToT. #

Patch Set 6 : Removed logging and rebased on ToT. #

Patch Set 7 : Fix CreateOpenerProxiesForFrameTree and MimeHandlerViewContainer #

Patch Set 8 : Rebase on ToT (resolve conflicts). #

Patch Set 9 : Rebase on ToT to pick up split out patches. #

Patch Set 10 : Rebase on ToT. #

Patch Set 11 : Rebase to fix patch conflicts #

Patch Set 12 : Disable text autosizer on cross-process navigations. #

Patch Set 13 : Rebase on TextAutosizer fix. #

Patch Set 14 : Leave swapped out in Android. #

Total comments: 2

Patch Set 15 : Add a TODO. #

Patch Set 16 : Rebase on ToT. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M content/common/site_isolation_policy.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 34 (16 generated)
Avi (use Gerrit)
Nasko: You asked me to look at the HistoryController, but your change isn't about that, ...
5 years, 6 months ago (2015-06-24 14:59:43 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1199313006/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1199313006/140001
5 years, 3 months ago (2015-09-12 23:51:53 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/99091)
5 years, 3 months ago (2015-09-12 23:59:35 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1199313006/180001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1199313006/180001
5 years, 3 months ago (2015-09-24 13:55:05 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1199313006/240001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1199313006/240001
5 years, 2 months ago (2015-09-29 00:05:43 UTC) #11
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/74886)
5 years, 2 months ago (2015-09-29 06:08:09 UTC) #13
nasko
Hey Charlie, Can you review this CL for me? As we chatted, this CL still ...
5 years, 2 months ago (2015-09-29 19:55:15 UTC) #16
Charlie Reis
I'm so excited to LGTM this! CL description nit: Add "on desktop" to the end ...
5 years, 2 months ago (2015-09-29 19:58:22 UTC) #17
nasko
https://codereview.chromium.org/1199313006/diff/260001/content/common/site_isolation_policy.cc File content/common/site_isolation_policy.cc (right): https://codereview.chromium.org/1199313006/diff/260001/content/common/site_isolation_policy.cc#newcode75 content/common/site_isolation_policy.cc:75: #if defined(OS_ANDROID) On 2015/09/29 19:58:22, Charlie Reis wrote: > ...
5 years, 2 months ago (2015-09-29 22:36:13 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1199313006/280001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1199313006/280001
5 years, 2 months ago (2015-09-29 22:40:15 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/89217)
5 years, 2 months ago (2015-09-29 22:50:13 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1199313006/300001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1199313006/300001
5 years, 2 months ago (2015-09-29 22:55:00 UTC) #26
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/builds/47140)
5 years, 2 months ago (2015-09-29 23:02:44 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1199313006/300001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1199313006/300001
5 years, 2 months ago (2015-09-29 23:52:56 UTC) #30
commit-bot: I haz the power
Committed patchset #16 (id:300001)
5 years, 2 months ago (2015-09-30 00:18:01 UTC) #31
commit-bot: I haz the power
Patchset 16 (id:??) landed as https://crrev.com/b8cc9ba3b9d0b8478bfd5d63130dfcfc69fbe6e6 Cr-Commit-Position: refs/heads/master@{#351446}
5 years, 2 months ago (2015-09-30 00:18:43 UTC) #32
zhaoqin1
A revert of this CL (patchset #16 id:300001) has been created in https://codereview.chromium.org/1374543004/ by zhaoqin@chromium.org. ...
5 years, 2 months ago (2015-09-30 18:09:22 UTC) #33
nasko
5 years, 2 months ago (2015-09-30 18:41:18 UTC) #34
Message was sent while issue was closed.
On 2015/09/30 18:09:22, zhaoqin1 wrote:
> A revert of this CL (patchset #16 id:300001) has been created in
> https://codereview.chromium.org/1374543004/ by mailto:zhaoqin@chromium.org.
> 
> The reason for reverting is: This CL is the culprit of
> RenderFrameHostManagerTest.NoScriptAccessAfterSwapOut content_browsertests
> failure on TSan bots
> 
> BUG=537689.

Can you please include a link to the failing bot and/or copy relevant logs here?

Powered by Google App Engine
This is Rietveld 408576698