Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1374423002: Add UBsan vtpr support to GN. (Closed)

Created:
5 years, 2 months ago by Anand Mistry (off Chromium)
Modified:
5 years, 2 months ago
Reviewers:
brettw
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@gn-ubsan
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add UBsan vtpr support to GN. BUG=527515 Committed: https://crrev.com/7f05a012be0c8c3950971111e4f750e8b3827816 Cr-Commit-Position: refs/heads/master@{#353485}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebase and address comment #

Patch Set 3 : Don't use libc++ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -9 lines) Patch
M build/config/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M build/config/compiler/BUILD.gn View 1 1 chunk +2 lines, -2 lines 0 comments Download
M build/config/sanitizers/BUILD.gn View 1 3 chunks +12 lines, -1 line 0 comments Download
M build/config/sanitizers/sanitizers.gni View 1 2 3 chunks +9 lines, -5 lines 0 comments Download
M build/toolchain/gcc_toolchain.gni View 1 1 chunk +1 line, -0 lines 0 comments Download

Depends on Patchset:

Issue 1379503002 Patch 40001

Messages

Total messages: 14 (5 generated)
Anand Mistry (off Chromium)
5 years, 2 months ago (2015-09-30 01:38:16 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1374423002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1374423002/1
5 years, 2 months ago (2015-09-30 01:39:24 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-09-30 02:10:06 UTC) #6
Anand Mistry (off Chromium)
Ping!
5 years, 2 months ago (2015-10-06 22:44:20 UTC) #7
brettw
Sorry! LGTM https://codereview.chromium.org/1374423002/diff/1/build/config/sanitizers/sanitizers.gni File build/config/sanitizers/sanitizers.gni (right): https://codereview.chromium.org/1374423002/diff/1/build/config/sanitizers/sanitizers.gni#newcode55 build/config/sanitizers/sanitizers.gni:55: # TODO(GYP) bug 527515: is_ubsan, is_ubsan_vptr Can ...
5 years, 2 months ago (2015-10-09 20:14:28 UTC) #8
Anand Mistry (off Chromium)
Something changed which prevents ubsan_vptr from working with libc++, so I've reverted that part from ...
5 years, 2 months ago (2015-10-12 04:28:56 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1374423002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1374423002/40001
5 years, 2 months ago (2015-10-12 04:29:27 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 2 months ago (2015-10-12 04:58:53 UTC) #13
commit-bot: I haz the power
5 years, 2 months ago (2015-10-12 04:59:38 UTC) #14
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/7f05a012be0c8c3950971111e4f750e8b3827816
Cr-Commit-Position: refs/heads/master@{#353485}

Powered by Google App Engine
This is Rietveld 408576698