build/config/compiler/BUILD.gn - Issue 1374423002: Add UBsan vtpr support to GN.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/config/compiler/BUILD.gn

Issue 1374423002: Add UBsan vtpr support to GN. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@gn-ubsan

Patch Set: Don't use libc++ Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/config/compiler/BUILD.gn

diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn

index de7167d7c2247532b32530ca1ea4c57fd2fbfeb6..e3dfffbacedc83b08e7cf963e773208abaeca049 100644

--- a/build/config/compiler/BUILD.gn

+++ b/build/config/compiler/BUILD.gn

@@ -848,8 +848,8 @@ config("rtti") {

}

config("no_rtti") {

- # CFI diagnostics require RTTI.

- if (!use_cfi_diag) {

+ # CFI diagnostics and UBsan vptr require RTTI.

+ if (!use_cfi_diag && !is_ubsan_vptr) {

if (is_win) {

cflags_cc = [ "/GR-" ]

} else {

« no previous file with comments | « build/config/BUILD.gn ('k') | build/config/sanitizers/BUILD.gn » ('j') | no next file with comments »