Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1379503002: Add Undefined Behaviour sanitizer support to GN. (Closed)

Created:
5 years, 2 months ago by Anand Mistry (off Chromium)
Modified:
5 years, 2 months ago
Reviewers:
brettw
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add Undefined Behaviour sanitizer support to GN. BUG=527515 Committed: https://crrev.com/e4309543a4dcca98d54ae0ae44cb2eaa3f287c95 Cr-Commit-Position: refs/heads/master@{#351447}

Patch Set 1 #

Patch Set 2 : Rebase #

Total comments: 4

Patch Set 3 : Review comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -6 lines) Patch
M build/config/BUILD.gn View 1 1 chunk +3 lines, -0 lines 0 comments Download
M build/config/compiler/BUILD.gn View 1 2 1 chunk +1 line, -1 line 0 comments Download
M build/config/compiler/compiler.gni View 1 2 1 chunk +1 line, -1 line 0 comments Download
M build/config/sanitizers/BUILD.gn View 1 3 chunks +35 lines, -1 line 0 comments Download
M build/config/sanitizers/sanitizers.gni View 3 chunks +7 lines, -3 lines 0 comments Download
M build/toolchain/gcc_toolchain.gni View 1 1 chunk +1 line, -0 lines 0 comments Download

Dependent Patchsets:

Issue 1374423002 Patch 1
Issue 1374423002 Patch 20001
Issue 1374423002 Patch 40001

Messages

Total messages: 9 (3 generated)
Anand Mistry (off Chromium)
5 years, 2 months ago (2015-09-29 04:40:57 UTC) #2
brettw
lgtm https://codereview.chromium.org/1379503002/diff/20001/build/config/compiler/BUILD.gn File build/config/compiler/BUILD.gn (right): https://codereview.chromium.org/1379503002/diff/20001/build/config/compiler/BUILD.gn#newcode415 build/config/compiler/BUILD.gn:415: if (!is_asan && !is_msan && !is_lsan && !is_tsan ...
5 years, 2 months ago (2015-09-29 20:05:03 UTC) #3
Anand Mistry (off Chromium)
Next up, is_ubsan_vptr. https://codereview.chromium.org/1379503002/diff/20001/build/config/compiler/BUILD.gn File build/config/compiler/BUILD.gn (right): https://codereview.chromium.org/1379503002/diff/20001/build/config/compiler/BUILD.gn#newcode415 build/config/compiler/BUILD.gn:415: if (!is_asan && !is_msan && !is_lsan ...
5 years, 2 months ago (2015-09-29 23:28:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1379503002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1379503002/40001
5 years, 2 months ago (2015-09-29 23:33:40 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 2 months ago (2015-09-30 00:18:45 UTC) #8
commit-bot: I haz the power
5 years, 2 months ago (2015-09-30 00:31:51 UTC) #9
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/e4309543a4dcca98d54ae0ae44cb2eaa3f287c95
Cr-Commit-Position: refs/heads/master@{#351447}

Powered by Google App Engine
This is Rietveld 408576698