Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1977)

Unified Diff: build/android/adb_gdb

Issue 1374303004: Make adb_gdb work for GN builds (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/android/BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/adb_gdb
diff --git a/build/android/adb_gdb b/build/android/adb_gdb
index 65ec7b20b87df53f1de71e9ac4d31e3cad6c1ee4..2d670dd8e9f0b495041dfd16d96be1e706bb5130 100755
--- a/build/android/adb_gdb
+++ b/build/android/adb_gdb
@@ -707,12 +707,14 @@ get_file_timestamp () {
#
detect_symbol_dir () {
local SUBDIRS SUBDIR LIST DIR DIR_LIBS TSTAMP
- # Note: Ninja places debug libraries under out/$BUILDTYPE/lib/, while
- # Make places then under out/$BUILDTYPE/lib.target.
+ # Make places them under out/$BUILDTYPE/lib.target.
+ # GYP places debug libraries under out/$BUILDTYPE/lib
+ # GN places them under out/$BUILDTYPE/lib.unstripped
if [ "$1" ]; then
- SUBDIRS="$1/lib $1/lib.target"
+ SUBDIRS="$1/lib $1/lib.target $1/lib.unstripped"
else
SUBDIRS="Release/lib Debug/lib Release/lib.target Debug/lib.target"
+ SUBDIRS+=" Release/lib.unstripped Debug/lib.unstripped"
fi
LIST=$TMPDIR/scan-subdirs-$$.txt
printf "" > "$LIST"
« no previous file with comments | « build/android/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698