Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(776)

Unified Diff: chrome/browser/task_management/providers/task.h

Issue 1374283003: Reporting top cpu and memory consumers via rappor on chromeos (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: browser/gpu stats by UMA histograms, buckets for cpu cores. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/task_management/providers/task.h
diff --git a/chrome/browser/task_management/providers/task.h b/chrome/browser/task_management/providers/task.h
index 5fa551f56326e2d28435cc89b9b88cc93b48dff1..550e7be7e1fed9c74d58fd43e660d1834982fc04 100644
--- a/chrome/browser/task_management/providers/task.h
+++ b/chrome/browser/task_management/providers/task.h
@@ -37,8 +37,11 @@ class Task {
};
// Create a task with the given |title| and the given favicon |icon|. This
- // task runs on a process whose handle is |handle|.
+ // task runs on a process whose handle is |handle|. |rappor_sample| is the
+ // name of the sample to be recorded if this task needs to be reported by
+ // Rappor.
Task(const base::string16& title,
+ const std::string& rappor_sample,
const gfx::ImageSkia* icon,
base::ProcessHandle handle);
virtual ~Task();
@@ -97,12 +100,16 @@ class Task {
int64 task_id() const { return task_id_; }
int64 network_usage() const { return network_usage_; }
const base::string16& title() const { return title_; }
+ const std::string& rappor_sample_name() const { return rappor_sample_name_; }
const gfx::ImageSkia& icon() const { return icon_; }
const base::ProcessHandle& process_handle() const { return process_handle_; }
const base::ProcessId& process_id() const { return process_id_; }
protected:
void set_title(const base::string16& new_title) { title_ = new_title; }
+ void set_rappor_sample_name(const std::string& sample) {
+ rappor_sample_name_ = sample;
+ }
void set_icon(const gfx::ImageSkia& new_icon) { icon_ = new_icon; }
private:
@@ -121,6 +128,10 @@ class Task {
// The title of the task.
base::string16 title_;
+ // The name of the sample representing this task when a Rappor sample needs to
+ // be recorded for it.
+ std::string rappor_sample_name_;
+
// The favicon.
gfx::ImageSkia icon_;

Powered by Google App Engine
This is Rietveld 408576698