chrome/browser/task_management/providers/child_process_task.cc - Issue 1374283003: Reporting top cpu and memory consumers via rappor on chromeos

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/task_management/providers/child_process_task.cc

Issue 1374283003: Reporting top cpu and memory consumers via rappor on chromeos (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: browser/gpu stats by UMA histograms, buckets for cpu cores. Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chromeos/resource_reporter/resource_reporter_unittest.cc ('K') | « chrome/browser/task_management/providers/browser_process_task.cc ('k') | chrome/browser/task_management/providers/task.h » ('j') | chrome/browser/task_management/providers/web_contents/renderer_task.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/task_management/providers/child_process_task.cc

diff --git a/chrome/browser/task_management/providers/child_process_task.cc b/chrome/browser/task_management/providers/child_process_task.cc

index b5a8cb7e5e74ff0f5a954dcee2036daa34443b88..f6d5ad712d45c011c47cfa6165462ea56c031ae9 100644

--- a/chrome/browser/task_management/providers/child_process_task.cc

+++ b/chrome/browser/task_management/providers/child_process_task.cc

@@ -6,6 +6,7 @@

#include "base/i18n/rtl.h"

#include "base/numerics/safe_conversions.h"

+#include "base/strings/utf_string_conversions.h"

#include "chrome/browser/process_resource_usage.h"

#include "chrome/browser/task_management/task_manager_observer.h"

#include "chrome/grit/generated_resources.h"

@@ -131,6 +132,7 @@ ProcessResourceUsage* CreateProcessResourcesSampler(

ChildProcessTask::ChildProcessTask(const content::ChildProcessData& data)

: Task(GetLocalizedTitle(data.name, data.process_type),

+ base::UTF16ToASCII(data.name),

GetDefaultIcon(),

data.handle),

process_resources_sampler_(CreateProcessResourcesSampler(data.id)),