Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Unified Diff: chrome/browser/task_management/providers/web_contents/renderer_task.cc

Issue 1374283003: Reporting top cpu and memory consumers via rappor on chromeos (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: browser/gpu stats by UMA histograms, buckets for cpu cores. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/task_management/providers/web_contents/renderer_task.cc
diff --git a/chrome/browser/task_management/providers/web_contents/renderer_task.cc b/chrome/browser/task_management/providers/web_contents/renderer_task.cc
index ca30ac750dd15e99591707ebeb60063e23cd64a9..2f51ec5335ee01f09b7bd81a75c4c43f6be89334 100644
--- a/chrome/browser/task_management/providers/web_contents/renderer_task.cc
+++ b/chrome/browser/task_management/providers/web_contents/renderer_task.cc
@@ -59,13 +59,20 @@ inline bool IsRendererResourceSamplingDisabled(int64 flags) {
return (flags & (REFRESH_TYPE_V8_MEMORY | REFRESH_TYPE_WEBCACHE_STATS)) == 0;
}
+std::string GetRapporSampleName(content::WebContents* web_contents) {
+ return web_contents->GetVisibleURL().host();
ncarter (slow) 2015/11/10 23:29:57 I recommend capturing the origin (GURL::GetOrigin(
afakhry 2015/11/12 00:21:28 Done.
+}
+
} // namespace
RendererTask::RendererTask(const base::string16& title,
const gfx::ImageSkia* icon,
content::WebContents* web_contents,
content::RenderProcessHost* render_process_host)
- : Task(title, icon, render_process_host->GetHandle()),
+ : Task(title,
+ GetRapporSampleName(web_contents),
+ icon,
+ render_process_host->GetHandle()),
web_contents_(web_contents),
render_process_host_(render_process_host),
renderer_resources_sampler_(
@@ -91,6 +98,10 @@ RendererTask::~RendererTask() {
RemoveObserver(this);
}
+void RendererTask::UpdateRapporSampleName() {
+ set_rappor_sample_name(GetRapporSampleName(web_contents()));
+}
+
void RendererTask::Activate() {
if (!web_contents_->GetDelegate())
return;

Powered by Google App Engine
This is Rietveld 408576698