Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1172)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1373883003: Move geolocation and permission mojoms into components. (Closed)

Created:
5 years, 2 months ago by Sam McNally
Modified:
4 years, 8 months ago
Reviewers:
CC:
chromium-reviews, qsr+mojo_chromium.org, zea+watch_chromium.org, viettrungluu+watch_chromium.org, posciak+watch_chromium.org, johnme+watch_chromium.org, nasko+codewatch_chromium.org, yzshen+watch_chromium.org, ben+mojo_chromium.org, tim+watch_chromium.org, mlamouri+watch-geolocation_chromium.org, mvanouwerkerk+watch_chromium.org, lcwu+watch_chromium.org, jam, abarth-chromium, pvalenzuela+watch_chromium.org, darin-cc_chromium.org, jkarlin+watch_chromium.org, halliwell+watch_chromium.org, android-webview-reviews_chromium.org, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, mlamouri+watch-notifications_chromium.org, feature-media-reviews_chromium.org, Michael van Ouwerkerk, mlamouri+watch-permissions_chromium.org, gunsch+watch_chromium.org, mkwst+moarreviews-shell_chromium.org, peter+watch_chromium.org, jochen+watch_chromium.org, toyoshim+midi_chromium.org, maxbogue+watch_chromium.org, mcasas+watch_chromium.org, Aaron Boodman, plaree+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, eme-reviews_chromium.org, darin (slow to review)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move geolocation and permission mojoms into components.

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Patch Set 8 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+405 lines, -509 lines) Patch
M android_webview/browser/aw_permission_manager.h View 1 2 3 4 5 6 3 chunks +6 lines, -7 lines 0 comments Download
M android_webview/browser/aw_permission_manager.cc View 1 2 3 4 5 6 7 14 chunks +24 lines, -25 lines 0 comments Download
M chrome/browser/DEPS View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/permissions/permission_context_uma_util.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/permissions/permission_manager.h View 1 3 chunks +6 lines, -7 lines 0 comments Download
M chrome/browser/permissions/permission_manager.cc View 1 11 chunks +16 lines, -16 lines 0 comments Download
M chrome/browser/permissions/permission_manager_unittest.cc View 11 chunks +22 lines, -30 lines 0 comments Download
M chrome/browser/push_messaging/push_messaging_service_impl.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/push_messaging/push_messaging_service_impl.cc View 1 2 chunks +6 lines, -6 lines 0 comments Download
M chromecast/browser/cast_permission_manager.h View 1 2 chunks +5 lines, -6 lines 0 comments Download
M chromecast/browser/cast_permission_manager.cc View 1 2 3 4 5 6 3 chunks +5 lines, -5 lines 0 comments Download
A + components/geolocation/public/interfaces/BUILD.gn View 1 1 chunk +2 lines, -1 line 0 comments Download
A + components/geolocation/public/interfaces/geolocation.mojom View 2 chunks +3 lines, -3 lines 0 comments Download
A components/geolocation/public/interfaces/geolocation_interfaces.gyp View 1 2 3 4 5 6 1 chunk +20 lines, -0 lines 0 comments Download
A + components/geolocation/public/interfaces/geoposition.mojom View 1 chunk +7 lines, -7 lines 0 comments Download
A + components/permission/public/interfaces/BUILD.gn View 1 1 chunk +2 lines, -1 line 0 comments Download
A + components/permission/public/interfaces/permission.mojom View 2 chunks +14 lines, -14 lines 0 comments Download
A components/permission/public/interfaces/permission_interfaces.gyp View 1 2 3 4 5 6 1 chunk +20 lines, -0 lines 0 comments Download
A + components/permission/public/interfaces/permission_status.mojom View 1 chunk +2 lines, -2 lines 0 comments Download
M content/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/BUILD.gn View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/DEPS View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/background_sync/background_sync_service_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/geolocation/geolocation_service_context.h View 1 chunk +3 lines, -2 lines 0 comments Download
M content/browser/geolocation/geolocation_service_context.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/geolocation/geolocation_service_impl.h View 4 chunks +4 lines, -5 lines 0 comments Download
M content/browser/geolocation/geolocation_service_impl.cc View 3 chunks +2 lines, -3 lines 0 comments Download
M content/browser/media/cdm/browser_cdm_manager.h View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/media/cdm/browser_cdm_manager.cc View 1 1 chunk +5 lines, -4 lines 0 comments Download
M content/browser/permissions/permission_service_context.h View 1 2 chunks +6 lines, -2 lines 0 comments Download
M content/browser/permissions/permission_service_context.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/permissions/permission_service_impl.h View 1 4 chunks +21 lines, -20 lines 0 comments Download
M content/browser/permissions/permission_service_impl.cc View 1 11 chunks +35 lines, -35 lines 0 comments Download
M content/child/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M content/child/background_sync/background_sync_provider.h View 1 1 chunk +1 line, -1 line 0 comments Download
M content/child/background_sync/background_sync_provider.cc View 1 2 2 chunks +5 lines, -5 lines 0 comments Download
M content/child/permissions/permission_dispatcher.h View 4 chunks +9 lines, -9 lines 0 comments Download
M content/child/permissions/permission_dispatcher.cc View 10 chunks +35 lines, -41 lines 0 comments Download
M content/common/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M content/common/background_sync_service.mojom View 1 2 chunks +2 lines, -2 lines 0 comments Download
D content/common/geolocation_service.mojom View 1 chunk +0 lines, -20 lines 0 comments Download
D content/common/permission_service.mojom View 1 chunk +0 lines, -42 lines 0 comments Download
M content/content_common_mojo_bindings.gyp View 1 2 3 4 5 6 3 chunks +2 lines, -4 lines 0 comments Download
M content/public/browser/permission_manager.h View 1 4 chunks +4 lines, -4 lines 0 comments Download
M content/public/common/BUILD.gn View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
D content/public/common/mojo_geoposition.mojom View 1 chunk +0 lines, -56 lines 0 comments Download
D content/public/common/permission_status.mojom View 1 chunk +0 lines, -12 lines 0 comments Download
M content/renderer/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/geolocation_dispatcher.h View 2 chunks +6 lines, -6 lines 0 comments Download
M content/renderer/geolocation_dispatcher.cc View 2 4 chunks +9 lines, -10 lines 0 comments Download
M content/renderer/media/media_permission_dispatcher_impl.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/media/media_permission_dispatcher_impl.cc View 2 chunks +7 lines, -7 lines 0 comments Download
M content/renderer/media/midi_dispatcher.h View 3 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/media/midi_dispatcher.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M content/renderer/notification_permission_dispatcher.h View 2 chunks +3 lines, -4 lines 0 comments Download
M content/renderer/notification_permission_dispatcher.cc View 2 chunks +7 lines, -8 lines 0 comments Download
M content/shell/browser/layout_test/layout_test_message_filter.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/shell/browser/layout_test/layout_test_message_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/browser/layout_test/layout_test_notification_manager.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M content/shell/browser/layout_test/layout_test_permission_manager.h View 1 3 chunks +9 lines, -9 lines 0 comments Download
M content/shell/browser/layout_test/layout_test_permission_manager.cc View 1 8 chunks +9 lines, -9 lines 0 comments Download
M content/shell/browser/layout_test/layout_test_push_messaging_service.cc View 1 1 chunk +4 lines, -4 lines 0 comments Download
M content/shell/browser/shell_permission_manager.h View 1 2 chunks +5 lines, -5 lines 0 comments Download
M content/shell/browser/shell_permission_manager.cc View 1 2 4 chunks +7 lines, -6 lines 0 comments Download
M content/shell/common/layout_test/layout_test_messages.h View 2 chunks +6 lines, -6 lines 0 comments Download
M content/shell/renderer/layout_test/blink_test_runner.cc View 1 2 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 1 (1 generated)
Sam McNally
5 years, 2 months ago (2015-09-30 01:19:40 UTC) #1 
Patchset #1 (id:1) has been deleted

Powered by Google App Engine
This is Rietveld 408576698