Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Side by Side Diff: chrome/browser/permissions/permission_context_uma_util.cc

Issue 1373883003: Move geolocation and permission mojoms into components. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/DEPS ('k') | chrome/browser/permissions/permission_manager.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/permissions/permission_context_uma_util.h" 5 #include "chrome/browser/permissions/permission_context_uma_util.h"
6 6
7 #include "base/metrics/histogram_macros.h" 7 #include "base/metrics/histogram_macros.h"
8 #include "base/strings/stringprintf.h" 8 #include "base/strings/stringprintf.h"
9 #include "chrome/browser/browser_process.h" 9 #include "chrome/browser/browser_process.h"
10 #include "chrome/browser/permissions/permission_manager.h" 10 #include "chrome/browser/permissions/permission_manager.h"
(...skipping 262 matching lines...) Expand 10 before | Expand all | Expand 10 after
273 273
274 // In order to gauge the compatibility risk of implementing an improved 274 // In order to gauge the compatibility risk of implementing an improved
275 // iframe permissions security model, we would like to know the ratio of 275 // iframe permissions security model, we would like to know the ratio of
276 // same-origin to cross-origin permission requests. Our estimate of this 276 // same-origin to cross-origin permission requests. Our estimate of this
277 // ratio could be somewhat biased by repeated requests coming from a 277 // ratio could be somewhat biased by repeated requests coming from a
278 // single frame, but we expect this to be insignificant. 278 // single frame, but we expect this to be insignificant.
279 if (requesting_origin.GetOrigin() != embedding_origin.GetOrigin()) { 279 if (requesting_origin.GetOrigin() != embedding_origin.GetOrigin()) {
280 content::PermissionManager* manager = profile->GetPermissionManager(); 280 content::PermissionManager* manager = profile->GetPermissionManager();
281 if (!manager) 281 if (!manager)
282 return; 282 return;
283 content::PermissionStatus embedding_permission_status = 283 permission::Status embedding_permission_status =
284 manager->GetPermissionStatus(type, embedding_origin, embedding_origin); 284 manager->GetPermissionStatus(type, embedding_origin, embedding_origin);
285 285
286 base::HistogramBase* histogram = base::LinearHistogram::FactoryGet( 286 base::HistogramBase* histogram = base::LinearHistogram::FactoryGet(
287 "Permissions.Requested.CrossOrigin_" + PermissionTypeToString(type), 1, 287 "Permissions.Requested.CrossOrigin_" + PermissionTypeToString(type), 1,
288 content::PERMISSION_STATUS_LAST, content::PERMISSION_STATUS_LAST + 1, 288 permission::STATUS_LAST, permission::STATUS_LAST + 1,
289 base::HistogramBase::kUmaTargetedHistogramFlag); 289 base::HistogramBase::kUmaTargetedHistogramFlag);
290 histogram->Add(embedding_permission_status); 290 histogram->Add(embedding_permission_status);
291 } else { 291 } else {
292 UMA_HISTOGRAM_ENUMERATION( 292 UMA_HISTOGRAM_ENUMERATION(
293 "Permissions.Requested.SameOrigin", 293 "Permissions.Requested.SameOrigin",
294 static_cast<base::HistogramBase::Sample>(type), 294 static_cast<base::HistogramBase::Sample>(type),
295 static_cast<base::HistogramBase::Sample>(PermissionType::NUM)); 295 static_cast<base::HistogramBase::Sample>(PermissionType::NUM));
296 } 296 }
297 } 297 }
298 298
(...skipping 22 matching lines...) Expand all
321 321
322 void PermissionContextUmaUtil::PermissionDismissed( 322 void PermissionContextUmaUtil::PermissionDismissed(
323 ContentSettingsType permission, const GURL& requesting_origin) { 323 ContentSettingsType permission, const GURL& requesting_origin) {
324 RecordPermissionAction(permission, DISMISSED, requesting_origin); 324 RecordPermissionAction(permission, DISMISSED, requesting_origin);
325 } 325 }
326 326
327 void PermissionContextUmaUtil::PermissionIgnored( 327 void PermissionContextUmaUtil::PermissionIgnored(
328 ContentSettingsType permission, const GURL& requesting_origin) { 328 ContentSettingsType permission, const GURL& requesting_origin) {
329 RecordPermissionAction(permission, IGNORED, requesting_origin); 329 RecordPermissionAction(permission, IGNORED, requesting_origin);
330 } 330 }
OLDNEW
« no previous file with comments | « chrome/browser/DEPS ('k') | chrome/browser/permissions/permission_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698