content/browser/frame_host/render_frame_host_impl.cc - Issue 1373883003: Move geolocation and permission mojoms into components.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/render_frame_host_impl.cc

Issue 1373883003: Move geolocation and permission mojoms into components. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/background_sync/background_sync_service_impl.cc ('k') | content/browser/geolocation/geolocation_service_context.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/render_frame_host_impl.cc

diff --git a/content/browser/frame_host/render_frame_host_impl.cc b/content/browser/frame_host/render_frame_host_impl.cc

index 39e9fc5c4d805792d3c1c0e2739b5b8ac5143f44..48ce700bd2b054b0533ce861f9314a2465d7c3ba 100644

--- a/content/browser/frame_host/render_frame_host_impl.cc

+++ b/content/browser/frame_host/render_frame_host_impl.cc

@@ -1603,7 +1603,7 @@ void RenderFrameHostImpl::RegisterMojoServices() {

// TODO(creis): Bind process ID here so that GeolocationServiceImpl

// can perform permissions checks once site isolation is complete.

// crbug.com/426384

- GetServiceRegistry()->AddService<GeolocationService>(

+ GetServiceRegistry()->AddService(

base::Bind(&GeolocationServiceContext::CreateService,

base::Unretained(geolocation_service_context),

base::Bind(&RenderFrameHostImpl::DidUseGeolocationPermission,

@@ -1613,7 +1613,7 @@ void RenderFrameHostImpl::RegisterMojoServices() {

if (!permission_service_context_)

permission_service_context_.reset(new PermissionServiceContext(this));

- GetServiceRegistry()->AddService<PermissionService>(

+ GetServiceRegistry()->AddService(

base::Bind(&PermissionServiceContext::CreateService,

base::Unretained(permission_service_context_.get())));