Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 137383005: Devtools: UMA for InspectElement loading time was added (Closed)

Created:
6 years, 10 months ago by sergeyv
Modified:
6 years, 10 months ago
CC:
chromium-reviews, vsevik, yurys, paulirish+reviews_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Devtools: UMA for InspectElement loading time was added BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247994

Patch Set 1 #

Patch Set 2 : Formatting fix #

Total comments: 4

Patch Set 3 : Fix naming #

Patch Set 4 : Histograms.xml was added #

Total comments: 1

Patch Set 5 : Summary was rephrased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -1 line) Patch
M chrome/browser/devtools/devtools_embedder_message_dispatcher.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/devtools/devtools_embedder_message_dispatcher.cc View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/devtools/devtools_window.h View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/devtools/devtools_window.cc View 1 2 3 chunks +15 lines, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
sergeyv
6 years, 10 months ago (2014-01-29 11:38:07 UTC) #1
pfeldman
lgtm with a nit. Added tsepez@ for dispatcher OWNER's review. https://codereview.chromium.org/137383005/diff/20001/chrome/browser/devtools/devtools_embedder_message_dispatcher.h File chrome/browser/devtools/devtools_embedder_message_dispatcher.h (right): https://codereview.chromium.org/137383005/diff/20001/chrome/browser/devtools/devtools_embedder_message_dispatcher.h#newcode33 ...
6 years, 10 months ago (2014-01-29 13:51:34 UTC) #2
sergeyv
https://codereview.chromium.org/137383005/diff/20001/chrome/browser/devtools/devtools_embedder_message_dispatcher.h File chrome/browser/devtools/devtools_embedder_message_dispatcher.h (right): https://codereview.chromium.org/137383005/diff/20001/chrome/browser/devtools/devtools_embedder_message_dispatcher.h#newcode33 chrome/browser/devtools/devtools_embedder_message_dispatcher.h:33: virtual void InspectElementLoadingCompleted() = 0; On 2014/01/29 13:51:35, pfeldman ...
6 years, 10 months ago (2014-01-29 14:12:38 UTC) #3
Tom Sepez
lgtm
6 years, 10 months ago (2014-01-29 17:45:56 UTC) #4
sergeyv
Alexei, @asvitkine PTAL at histograms.xml, Thanks!
6 years, 10 months ago (2014-01-30 11:53:49 UTC) #5
Alexei Svitkine (slow)
LGTM with a nit. https://codereview.chromium.org/137383005/diff/50001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/137383005/diff/50001/tools/metrics/histograms/histograms.xml#newcode1839 tools/metrics/histograms/histograms.xml:1839: + Duration of a loading ...
6 years, 10 months ago (2014-01-30 14:13:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyv@chromium.org/137383005/70001
6 years, 10 months ago (2014-01-30 14:24:22 UTC) #7
commit-bot: I haz the power
Change committed as 247994
6 years, 10 months ago (2014-01-30 18:08:23 UTC) #8
commit-bot: I haz the power
6 years, 10 months ago (2014-01-30 18:08:24 UTC) #9
Message was sent while issue was closed. 
CQ bit was unchecked on CL. Ignoring.

Powered by Google App Engine
This is Rietveld 408576698