Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(531)

Unified Diff: chrome/browser/devtools/devtools_window.cc

Issue 137383005: Devtools: UMA for InspectElement loading time was added (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Summary was rephrased Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/devtools/devtools_window.h ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/devtools/devtools_window.cc
diff --git a/chrome/browser/devtools/devtools_window.cc b/chrome/browser/devtools/devtools_window.cc
index ce6f49696d0c26d05325567fad10c66a6297ba3b..f52dd9c68082b1c6d408811bea13d74cd8943c29 100644
--- a/chrome/browser/devtools/devtools_window.cc
+++ b/chrome/browser/devtools/devtools_window.cc
@@ -9,10 +9,12 @@
#include "base/json/json_reader.h"
#include "base/json/json_writer.h"
#include "base/lazy_instance.h"
+#include "base/metrics/histogram.h"
#include "base/prefs/scoped_user_pref_update.h"
#include "base/strings/string_number_conversions.h"
#include "base/strings/string_util.h"
#include "base/strings/utf_string_conversions.h"
+#include "base/time/time.h"
#include "base/values.h"
#include "chrome/browser/browser_process.h"
#include "chrome/browser/chrome_notification_types.h"
@@ -467,9 +469,13 @@ void DevToolsWindow::InspectElement(content::RenderViewHost* inspected_rvh,
scoped_refptr<DevToolsAgentHost> agent(
DevToolsAgentHost::GetOrCreateFor(inspected_rvh));
agent->InspectElement(x, y);
+ bool should_measure_time = FindDevToolsWindow(agent.get()) == NULL;
+ base::TimeTicks start_time = base::TimeTicks::Now();
// TODO(loislo): we should initiate DevTools window opening from within
// renderer. Otherwise, we still can hit a race condition here.
- OpenDevToolsWindow(inspected_rvh);
+ DevToolsWindow* window = OpenDevToolsWindow(inspected_rvh);
+ if (should_measure_time)
+ window->inspect_element_start_time_ = start_time;
}
// static
@@ -999,6 +1005,14 @@ void DevToolsWindow::SetContentsInsets(
}
}
+void DevToolsWindow::InspectElementCompleted() {
+ if (!inspect_element_start_time_.is_null()) {
+ UMA_HISTOGRAM_TIMES("DevTools.InspectElement",
+ base::TimeTicks::Now() - inspect_element_start_time_);
+ inspect_element_start_time_ = base::TimeTicks();
+ }
+}
+
void DevToolsWindow::MoveWindow(int x, int y) {
if (!is_docked_) {
gfx::Rect bounds = browser_->window()->GetBounds();
« no previous file with comments | « chrome/browser/devtools/devtools_window.h ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698