Devtools: UMA for InspectElement loading time was added

chrome/browser/devtools/devtools_window.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/devtools/devtools_window.h"
 #include <algorithm>
 
 #include "base/command_line.h"
 #include "base/json/json_reader.h"
 #include "base/json/json_writer.h"
 #include "base/lazy_instance.h"
+#include "base/metrics/histogram.h"
 #include "base/prefs/scoped_user_pref_update.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_util.h"
 #include "base/strings/utf_string_conversions.h"
+#include "base/time/time.h"
 #include "base/values.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/chrome_notification_types.h"
 #include "chrome/browser/extensions/api/debugger/debugger_api.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/extensions/extension_system.h"
 #include "chrome/browser/extensions/extension_web_contents_observer.h"
 #include "chrome/browser/file_select_helper.h"
 #include "chrome/browser/infobars/confirm_infobar_delegate.h"
 #include "chrome/browser/infobars/infobar.h"
@@ skipping 434 matching lines @@
   return window;
 }
 
 // static
 void DevToolsWindow::InspectElement(content::RenderViewHost* inspected_rvh,
                                     int x,
                                     int y) {
   scoped_refptr<DevToolsAgentHost> agent(
       DevToolsAgentHost::GetOrCreateFor(inspected_rvh));
   agent->InspectElement(x, y);
+  bool should_measure_time = FindDevToolsWindow(agent.get()) == NULL;
+  base::TimeTicks start_time = base::TimeTicks::Now();
   // TODO(loislo): we should initiate DevTools window opening from within
   // renderer. Otherwise, we still can hit a race condition here.
-  OpenDevToolsWindow(inspected_rvh);
+  DevToolsWindow* window = OpenDevToolsWindow(inspected_rvh);
+  if (should_measure_time) {

[pfeldman, 2014/01/29 13:51:35]

drop {}

[sergeyv, 2014/01/29 14:12:38]

Done.

+    window->inspect_element_start_time_ = start_time;
+  }
 }
 
 // static
 int DevToolsWindow::GetMinimizedHeight() {
   const int kMinimizedDevToolsHeight = 24;
   return kMinimizedDevToolsHeight;
 }
 
 void DevToolsWindow::InspectedContentsClosing() {
   intercepted_page_beforeunload_ = false;
@@ skipping 509 matching lines @@
 
   contents_insets_ = gfx::Insets(top, left, bottom, right);
   if (is_docked_) {
     // Update inspected window.
     BrowserWindow* inspected_window = GetInspectedBrowserWindow();
     if (inspected_window)
       inspected_window->UpdateDevTools();
   }
 }
 
+void DevToolsWindow::InspectElementLoadingCompleted() {
+  if (!inspect_element_start_time_.is_null()) {
+    UMA_HISTOGRAM_TIMES("DevTools.InspectElement",
+        base::TimeTicks::Now() - inspect_element_start_time_);
+    inspect_element_start_time_ = base::TimeTicks();
+  }
+}
+
 void DevToolsWindow::MoveWindow(int x, int y) {
   if (!is_docked_) {
     gfx::Rect bounds = browser_->window()->GetBounds();
     bounds.Offset(x, y);
     browser_->window()->SetBounds(bounds);
   }
 }
 
 void DevToolsWindow::SetIsDockedAndShowImmediatelyForTest(bool is_docked) {
   DCHECK(!is_docked || can_dock_);
@@ skipping 461 matching lines @@
   if (load_state_ == kLoadCompleted)
     LoadCompleted();
 }
 
 void DevToolsWindow::LoadCompleted() {
   Show(action_on_load_);
   action_on_load_ = DevToolsToggleAction::NoOp();
   UpdateTheme();
   AddDevToolsExtensionsToClient();
 }