Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 1373373003: Mac Overlays: Add AllOrNothing strategy (Closed)

Created:
5 years, 2 months ago by Andre
Modified:
5 years, 2 months ago
Reviewers:
ccameron
CC:
chromium-reviews, cc-bugs_chromium.org, alexst (slow to review)
Base URL:
https://chromium.googlesource.com/chromium/src.git@OverlayTest
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mac Overlays: Add AllOrNothing strategy This strategy attempts to promote all quads into overlays. If any quad can't be promoted, no quads are promoted. BUG=533687 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/351654665d1cce4d5297e467392c42e136734ab7 Cr-Commit-Position: refs/heads/master@{#351896}

Patch Set 1 #

Total comments: 8

Patch Set 2 : For ccameron #

Patch Set 3 : Validate negative z-order #

Patch Set 4 : Rebase off master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+301 lines, -184 lines) Patch
M cc/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M cc/cc.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M cc/output/overlay_candidate.h View 1 2 chunks +16 lines, -10 lines 0 comments Download
M cc/output/overlay_candidate.cc View 1 4 chunks +133 lines, -30 lines 0 comments Download
A cc/output/overlay_strategy_all_or_nothing.h View 1 2 3 1 chunk +35 lines, -0 lines 0 comments Download
A cc/output/overlay_strategy_all_or_nothing.cc View 1 2 3 1 chunk +44 lines, -0 lines 0 comments Download
M cc/output/overlay_strategy_common.h View 1 chunk +0 lines, -12 lines 0 comments Download
M cc/output/overlay_strategy_common.cc View 2 3 3 chunks +1 line, -127 lines 0 comments Download
M cc/output/overlay_strategy_sandwich.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M cc/output/overlay_unittest.cc View 1 2 3 4 chunks +65 lines, -0 lines 0 comments Download
M content/browser/compositor/browser_compositor_overlay_candidate_validator_mac.mm View 1 2 1 chunk +2 lines, -4 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 17 (7 generated)
Andre
ccameron PTAL.
5 years, 2 months ago (2015-09-29 23:07:50 UTC) #3
ccameron
lg -- couple of suggestions. Let's try to resolve this against https://codereview.chromium.org/1376883004/, too (I don't ...
5 years, 2 months ago (2015-09-29 23:29:56 UTC) #4
Andre
Now resolved with https://codereview.chromium.org/1376883004/. PTAL. https://codereview.chromium.org/1373373003/diff/20001/cc/output/overlay_candidate.cc File cc/output/overlay_candidate.cc (right): https://codereview.chromium.org/1373373003/diff/20001/cc/output/overlay_candidate.cc#newcode61 cc/output/overlay_candidate.cc:61: candidate->display_rect = GetOverlayRect( On ...
5 years, 2 months ago (2015-09-30 00:18:38 UTC) #5
ccameron
lgtm Go and land this ahead without my CL (it looks like it won't get ...
5 years, 2 months ago (2015-09-30 01:27:36 UTC) #6
Andre
On 2015/09/30 01:27:36, ccameron wrote: > lgtm > > Go and land this ahead without ...
5 years, 2 months ago (2015-09-30 16:15:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1373373003/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1373373003/100001
5 years, 2 months ago (2015-10-01 20:30:48 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/111842)
5 years, 2 months ago (2015-10-01 20:48:02 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1373373003/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1373373003/100001
5 years, 2 months ago (2015-10-01 21:10:10 UTC) #15
commit-bot: I haz the power
Committed patchset #4 (id:100001)
5 years, 2 months ago (2015-10-01 21:50:28 UTC) #16
commit-bot: I haz the power
5 years, 2 months ago (2015-10-01 21:51:37 UTC) #17
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/351654665d1cce4d5297e467392c42e136734ab7
Cr-Commit-Position: refs/heads/master@{#351896}

Powered by Google App Engine
This is Rietveld 408576698